On Mon, Mar 26, 2018 at 1:21 PM, Jorge Gustavo Rocha <j...@geomaster.pt>
wrote:
> Hi Andrea,
>
> I have no vote to cast. But I like the option to include some code
> styling check on Travis. We do that in QGIS and it works. Maybe
> checkstyle [1] is fine for our JAVA projects.
>
Hi Jorge,
I've checked checkstyle and found it would require a massive amount of
manual changes.
Even after a full reformat made by IntelliJ, checkstyle found hundreds of
failures for
each single rule I've tried (basic ones!):
https://github.com/aaime/geotools/blob/intellij_checkstyle2/pom.xml#L1766
Long story short, having a different tool to do the reformat and to do the
checks
does not seem to work, or at the very least, it would, but would also
require
a significant up-front effort to make the codebase compliant (like, a week
worth
of code sprint with a few people).
> I can see that you and Ben are the ones managing the CI (thanks!). Are
> you planning to include this code style enforcement on Travis? How it
> would be? We could use the same script to do a local check on a pre
> commit hook.
>
The Google checker would run at every build, no matter what (it would break
your own
local build before you can make the pull request). If there is one good
thing about the Google
tooling, it is the performance of the tool, can check/reformat the whole
GeoTools codebase
in like 15-20 seconds (using a -T8 build).
>
> For personal usage, I've downloaded and installed AOSP code rules from
> [2] for IntelliJ Idea and it seems to work.
>
Nice
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
