Hi Andrea,
Thanks for the effort. My thinking is that a global reformat is badly
needed one way or the other. My preference is for the AOSP with automated
checking, but barring that I am also happy with at a minimum a one time
full reformat. Barring that, I also voted for one time reformats.
Cheers,
Devon
On Mon, Mar 26, 2018 at 12:13 PM, Torben Barsballe <
[email protected]> wrote:
>
>
> On Mon, Mar 26, 2018 at 9:55 AM, Andrea Aime <[email protected]
> > wrote:
>
>> On Mon, Mar 26, 2018 at 6:50 PM, Torben Barsballe <
>> [email protected]> wrote:
>>
>>> Thanks again for pushing forward with the codebase reformat. While I
>>> would prefer Intellij + Checkstyle due to configurability, I entirely
>>> understand that it requires an unreasonable amount of effort given the
>>> current availability of people.
>>>
>>
>> Yeah, I am in a agreement, would have the same preference if it was not
>> for the effort. Thinking out loud, if we had that much resource, I'd rather
>> use them for something else (like library upgrades, working on Java 10
>> compatibility or something like that).
>>
>>
> Yep, unfortunately reformatting is pretty low in priority when it comes to
> important things that need a lot of developer effort. I agree that those
> things would take priority if we had the developer availability for
> implementing checkstyle.
>
>
>> As an aside, a decent workaround for hand-indented XML (and similar) is
>>> to include the indentation inside the string. I imagine we'll want to do
>>> similar stuff throughout the codebase to retain certain structures in a way
>>> that is compatible with the new formatting rules.
>>>
>>
>> Thinking out loud, maybe we should just make it easier to use external
>> XML resources (an easy to use loader that also prints the XML on the
>> console for reference while coding).
>>
>> Adding external XML resources isn't really that difficult, but for small
> snippets (e.g. for 7 lines or less I don't think an external resource is
> ever going to be easier) or XML blocks that are largely the same with minor
> changes it can be more convenient to have them in the same file/method as
> the test (Given that, a simple utility for easily modifying specific
> elements might be worthwhile. There's plenty of ways to do that already,
> but most of them tend to be convoluted enough that it is usually easer to
> just make another file right now).
>
> Probably the biggest barrier to changing anything about how we handle XML
> resources is that whenever a new XML test / snippet / whatever is added, it
> is generally copied from an existing test case, so for any improvement to
> gain traction it will need to be widely used. Certainly something to think
> about though.
>
> Torben
>
>
>> Cheers
>> Andrea
>>
>> ==
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V for more information.
>> ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via di Montramito 3/A
>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>> 55054 Massarosa
>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>> (LU)
>> phone: +39 0584 962313 <+39%200584%20962313>
>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>
>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>> principi dettati dal D.Lgs. 196/2003.
>>
>> The information in this message and/or attachments, is intended solely
>> for the attention and use of the named addressee(s) and may be confidential
>> or proprietary in nature or covered by the provisions of privacy act
>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>> copying, distribution, or either dissemination, either whole or partial, is
>> strictly forbidden except previous formal approval of the named
>> addressee(s). If you are not the intended recipient, please contact
>> immediately the sender by telephone, fax or e-mail and delete the
>> information in this message that has been received in error. The sender
>> does not give any warranty or accept liability as the content, accuracy or
>> completeness of sent messages and accepts no responsibility for changes
>> made after they were sent or for other risks which arise as a result of
>> e-mail transmission, viruses, etc.
>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
