Hi Ben,
Thanks for the testing and merging !
I don't intend to extend the test setup to run on the database, at least for
now.
Regards,
Nuno Oliveira
On 03/27/2018 10:30 PM, Ben Caradoc-Davies wrote:
Nuno,
I have tested and merged your fix.
The default geometry test setup is quite complicated and might break the automatic conversion to
online tests. If you plan to update the conversion to support this test, please create a Jira
issue for this task.
I will run geoserver-master-app-schema-online-test once geoserver-master has
built.
Kind regards,
Ben.
On 28/03/18 09:23, Ben Caradoc-Davies wrote:
Nuno,
I am not aware of anything special about having "Geometry" in the test name. I thought *all*
tests using property files were automagically converted into online tests (a brilliant piece of
work by Rini). I will test your PR locally with app-schema online tests against postgis.
Kind regards,
Ben.
On 28/03/18 07:56, Nuno Oliveira wrote:
Hi,
So, yes this was caused by the default geometry support commit, my apologies :(
The interesting thing is that the default geometry tests are not mean to run as
online tests, so I was a bit surprised to see them running ...
I checked why they were running as online tests, since they were not configured
that way, and it turns out that apparently having /Geometry /in the test name
makes
you suitable to run as an online App-Schema test.
I could no find out why this is happening, I generated the effective pom and
there
was nothing supporting this, so I'm completely clueless ... anyone can shine a
light on this ?
That say, I make a PR [1] that explicitly excludes the DefaultGeometryeTest
from the
online test build ...
Cheers,
Nuno Oliveira
[1] https://github.com/geoserver/geoserver/pull/2816
On 03/27/2018 06:26 PM, Nuno Oliveira wrote:
Hi,
Looking into it ...
On 03/27/2018 06:13 PM, Torben Barsballe wrote:
Hello all,
Build pipeline has cleared up, nightlies should be up-to-date again.
The app-schema test still hangs if I re-run it, so this wasn't a fluke. Specifically, it hangs
when executing org.geoserver.test.DefaultIdTest.
The only app-schema change in the timeframe of this failure is from
https://github.com/geoserver/geoserver/pull/2804
Nuno - any comments here? The offline tests all seem to be working fine, the only failures are
in the online tests.
Torben
On Mon, Mar 26, 2018 at 11:55 AM, Torben Barsballe <[email protected]
<mailto:[email protected]>> wrote:
The last job
<https://build.geoserver.org/job/geoserver-master-app-schema-online/1112/console>
for
geoserver-master-app-schema-online hung for 4 days (which has backed up
build.geoserver.org
<http://build.geoserver.org>). I have canceled it.
The server is a bit backed up right now, so changes / nightly builds may
take a little while
to show up. I'm clearing out duplicates an will monitor the situation.
It may be worthwhile to consider something like the Build Timeout
<https://wiki.jenkins.io/display/JENKINS/Build-timeout+Plugin> plugin to handle
this sort of
thing in the future, since this seems to happen occasionally.
If anyone has an idea as to what might have caused those tests to hang up,
that would be good
to know. Based on the initial logging, the remote DB does appear to be up
and running.
Torben
--
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visithttp://goo.gl/it488V
for more information.
==
Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i
sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al
destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate
questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia
via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro
sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri
soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and
use of the named addressee(s) and may be confidential or proprietary in nature or covered by
the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data
Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying,
distribution, or either dissemination, either whole or partial, is strictly forbidden except
previous formal approval of the named addressee(s). If you are not the intended recipient,
please contact immediately the sender by telephone, fax or e-mail and delete the information in
this message that has been received in error. The sender does not give any warranty or accept
liability as the content, accuracy or completeness of sent messages and accepts no
responsibility for changes made after they were sent or for other risks which arise as a
result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i
file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo
è consentito esclusivamente al destinatario del messaggio, per le finalità
indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne
il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di
procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro
sistema. Conservare il messaggio stesso, divulgarlo anche in parte,
distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse,
costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
