Thanks for the detailed testing, some comments inline.
On Fri, 17 Sept 2021 at 04:18, Brad Hards <br...@frogmouth.net> wrote: > Javadoc - downloaded and successfully unzipped. Local browsing looks good > with > firefox. README.txt uses http instead of https (minor). > Here is a fix https://github.com/geoserver/geoserver/pull/5284 > > HTML docs - downloaded and successfully unzipped. Local browsing of user > manual, dev manual and api looks good with firefox. README.txt uses http > instead of https (minor). VERSION.txt doesn't have expected value > substitution: > version = 2.20-RC > git revision = ${build.commit.id} > git branch = ${build.branch} > build date = 2021-09-13T22:04:24Z > hudson build = ${build.hudsonId} > (minor) > I am not exactly sure how VERSION.txt is populated, I believe in the root pom.xml here <https://github.com/geoserver/geoserver/blob/ed5a4770600a72e314b225fe92db79b459afed6f/src/pom.xml#L2089-L2101> : <copy file="release/VERSION.txt" filtering="true" todir="target"> <filterset begintoken="$${" endtoken="}"> <filter token="project.version" value="${project.version}"></filter> <filter token="build.revision" value="${ build.commit.id}"></filter> <filter token="build.branch" value="${build.branch}"></filter> <filter token="build.timestamp" value="${build.timestamp}"></filter> <filter token="gt.version" value="${gt.version}"></filter> <filter token="gt.revision" value="${gt.Git-Revision}"></filter> <filter token="gwc.version" value="${gwc.version}"></filter> <filter token="gwc.revision" value="${gwc.Implementation-Version}"></filter> <filter token="build.hudsonId" value="${build.hudsonId}"></filter> </filterset> </copy> I am going to guess we need to update the jenkins job to provide those values missing values, some research here <https://issues.jenkins.io/browse/JENKINS-26520> indicates *Manage Jenkins > Configure System > Global Properties* This will be something for the 2.20.0 release volunteer to test/fix. > source tarball - downloaded and successfully unzipped. README needs http > -> > https at some point. Looks like its building against GT 2.26-RC. I am > getting > a failure on one of the tests, but that doesn't appear relevant. > Here is a fix https://github.com/geoserver/geoserver/pull/5284 > war - downloaded and successfully unzipped. VERSION has strange looking > hudson > build: > hudson build = -1 > but other parts look good (i.e. the substitution is working for that) > Booted it on tomcat9 and Ubuntu: 11.0.11 (OpenJDK 64-Bit Server VM), looks > OK. > > GeoServer Version > 2.20-RC > Git Revision > 757dd880f6916c48115cfd48981a655c3cf4ea4f > Build Date > 13-Sep-2021 21:54 > GeoTools Version > 26-RC (rev 1557529d304800cbe8015de7722aee9d60caab2f) > GeoWebCache Version > 1.20-RC (rev 1.20.x/a5c1c88f6474a8dc323ae501ae968af9d5cc064c) > I assume with the change from hudson to jenkins we did not update our scripts. Something for the release volunteer to test/fix when 2.20 is made. Checked a few layer preview entries. All good. > > Installed > geoserver-2.20-RC-charts-plugin.zip > geoserver-2.20-RC-csw-plugin.zip > geoserver-2.20-RC-excel-plugin.zip > geoserver-2.20-RC-mapml-plugin.zip > geoserver-2.20-RC-wps-download-plugin.zip > geoserver-2.20-RC-wps-plugin.zip > Can you confirm that those show up in the server status modules tab? Ian did a bunch of work and I would love a screen snap for the next release announcement. MapML looks nice in layer preview, except doesn't show anything for http:// > localhost:8080/geoserver/mapml/tiger-ny/osmtile/ > Haven't investigated that yet - other cases seem fine. > MapML adds some new gridset definitions, you probably need to configure tiger-ny to cache OSMTILE gridset. There was discussion about setting up alias so 900913 and OSMTILE would use the same cache. Still the requirement to add OSMTILE gridset is a subject for the MapML docs. Thanks again for testing Brad. Jody
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
