HTML docs - downloaded and successfully unzipped. Local browsing of user
> manual, dev manual and api looks good with firefox. README.txt uses http
>> instead of https (minor). VERSION.txt doesn't have expected value
>> substitution:
>> version = 2.20-RC
>> git revision = ${build.commit.id}
>> git branch = ${build.branch}
>> build date = 2021-09-13T22:04:24Z
>> hudson build = ${build.hudsonId}
>> (minor)
>>
>
> I am not exactly sure how VERSION.txt is populated, I believe in the root
> pom.xml here
> <https://github.com/geoserver/geoserver/blob/ed5a4770600a72e314b225fe92db79b459afed6f/src/pom.xml#L2089-L2101>
> :
>
> <copy file="release/VERSION.txt" filtering="true"
> todir="target">
> <filterset begintoken="$${" endtoken="}">
> <filter token="project.version"
> value="${project.version}"></filter>
> <filter token="build.revision" value="${
> build.commit.id}"></filter>
> <filter token="build.branch"
> value="${build.branch}"></filter>
> <filter token="build.timestamp"
> value="${build.timestamp}"></filter>
> <filter token="gt.version"
> value="${gt.version}"></filter>
> <filter token="gt.revision"
> value="${gt.Git-Revision}"></filter>
> <filter token="gwc.version"
> value="${gwc.version}"></filter>
> <filter token="gwc.revision"
> value="${gwc.Implementation-Version}"></filter>
> <filter token="build.hudsonId"
> value="${build.hudsonId}"></filter>
> </filterset>
> </copy>
>
> I am going to guess we need to update the jenkins job to provide those
> values missing values, some research here
> <https://issues.jenkins.io/browse/JENKINS-26520> indicates *Manage
> Jenkins > Configure System > Global Properties*
> This will be something for the 2.20.0 release volunteer to test/fix.
>
Did not find much in global properites, the related links are:
- https://build.geoserver.org/env-vars.html/
- https://github.com/geoserver/geoserver/blob/main/build/build_release.sh
Suggest:
- build.commit.id should probably figure this out from git after updating
version and tagging?
- build.branch may be from job parameter ${env.BRANCH}
- build hudson id be replaced with ${env.BUILD_NUMBER}
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
