Hi,
Thank you for your quick response!
I get the feeling that the ticket GEOS-5377 is not the same problem as I'm
having. I believe that my problem arises from these lines of code in
GetFeatureInfo.identifyVectorLayer:
FeatureCollection<? extends FeatureType, ? extends Feature> match;
match = featureSource.getFeatures(q);
// if we could not include the rules filter into the query, post
process in
// memory
if (!Filter.INCLUDE.equals(postFilter)) {
match = new FilteringFeatureCollection(match,
postFilter);
}
The query, q, in the call to the getFeatures method is defined as:
Query q = new Query(typeName, null, getFInfoFilter, maxFeatures,
propertyNames, null);
and I suspect that the maxFeatures variable that is used in creating the query
q is used to limit the number of features returned by the getFeatures method.
And if the rules of the SLD are applied afterwards as a postFilter, the number
of features actually returned by the GetFeatureInfo request may be lower than
maxFeatures.
I will attempt to recreate the problem in a test environment and if I succeed I
will post the results here.
/ Johan
Från: [email protected] [mailto:[email protected]] För Andrea Aime
Skickat: den 26 november 2013 14:53
Till: Johan Behrenfeldt
Kopia: Jonathan Moules; [email protected]
Ämne: Re: [Geoserver-users] WMS GetFeatureInfo requests that require post
filtering do not work well with maxFeatures
On Tue, Nov 26, 2013 at 2:48 PM, Johan Behrenfeldt
<[email protected]<mailto:[email protected]>> wrote:
Hi,
My mistake! Of course, I should've included that piece of information.
The version in which I encountered my problem is 2.1.3 (subversion: revision
16668).
If I look at the GEOS-5377 ticket, I can see that was fixed in version 2.2.2
and upgrading to version 2.2.2 or later may solve my problem. However, this is
an issue that I've encountered in a production environment where I cannot
upgrade GeoServer without going through a long process and I would want to be
rather certain that the upgrade will fix my problem before going through that
process.
Is there any way I can see what code changes were made to resolve the ticket?
Seeing what code was changed to fix the ticket would give me a chance to make a
qualified guess whether my problem has been solved or not.
Aaah... See, that makes it very easy to answer:
https://github.com/geoserver/geoserver/commit/9f159ded4f0c8da8c3742bdbdbb2463b9cf42a10
and as a patch:
https://github.com/geoserver/geoserver/commit/9f159ded4f0c8da8c3742bdbdbb2463b9cf42a10.patch
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-users
