maven has a jalopy plugin, we could make it part of the maven build to
format the source files.
Justin
Jody Garnett wrote:
[EMAIL PROTECTED] wrote:
Jody,
I'm not sure what you're saying, but running jalopy (or anything that
mangles the code) isnt a very good idea.
Running Jalopy kills history -- and makes branch-to-branch maintainance
difficult.
However it is GeoTools policy, any and all code is supposed to have
Jalopy run before you commit.
People were more strict about this when I started.
I had to waste a good chunk of a day merging changes in
StreamingRenderer.java from 2.1.x to trunk (and back) because someone
ran something that changed almost every line of code in the class.
Chris ran jalopy on something in Geoserver and I just gave up trying to
figure out what had changed (unfortunately his jalopy commit also had
code changes in it).
I'm FIRMLY -1 ; unless someone can argue that those two applications of
jalopy-like stuff will actually save more than a days of someone's time
(+ extra time for how frustrating & futile it is to sort through 10,000
changes). And this is *just* one java file. Running it for 3,000
files better save 10 people years!
I think the idea is *everyone* is supposed to run Jalopy thus with
common whitespace etc there
will be less formatting trouble of the kind you describe. And more of a
focus on change.
Jody
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log
files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
