I don't know who is the maitainer of the shapefile module...
I would like to commit the following changes. Those changes was needed
in order to get the Maven 2 build to run the tests. Basically, Maven 2
doesn't seem to allow fetching resources in the root package (for
security reason I guess; NetBeans doesn't allow that neither, and I
would bet that Eclipse neither).
- Moved /testData directory (in the root package) to
org/geotools/data/shapefile/test-data
- Replaced some methods in org.geotools.data.shapefile.TestCaseSupport
by calls to org.geotools.resources.TestData (which is designed for
working with "test-data" directories):
- getTestResource(...) --> TestData.url(...)
- getTestResourceAsStream(...) --> TestData.openStream(...)
- getTestReadableFileChannel(...) --> TestData.openChannel(...)
- prepareData() --> TestData.unzipFile(...)
- Conditionnaly disabled some println statements. I put them in an
"if (verbose) {...}" block. Verbose is on when the tests are run
from the command line, but off when the tests are run from Maven.
It make the tests a little bit less verbose, but they are still very
verbose. I have the feeling that the core shapefile module itself
contains a lot of println statements.
- Added "svn-keywords" attribute to .java files.
Can I commit those changes?
Second request: I though that the whole point about the "sample-data"
module was to provides the data in a simple location, so that various
module don't have to copy them again and again in their directory. Why
the shapefile module doesn't use "sample-data"? Can I update its test
suite in order to make use of this module instead of copying file like
"statepop" in its own directory?
Martin.
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
