Similarly the ones in legacy... As well as anything in test. Go ahead and send me what you get through as a patch, I can apply it. And I'll try to get to anything you don't do, shouldn't take too long.

Brent Owens wrote:
The validation ones won't be used very much, so put those as a low priority.

Brent Owens
(The Open Planning Project)



John Grange wrote:

Chris,

....removing the wc -l from the end of the queries ;-)

If you could take a quick look and let me know which ones would be higher priority for the project, I could concentrate on those first - should I send them to you?

Cheers,

John Grange

System.err:

gt/ext/validation/src/org/geotools/validation/DefaultFeatureResults.java: System.err.println( where + ":"+ message ); gt/ext/validation/src/org/geotools/validation/relate/TempFeatureResults.java: System.err.println( where + ":"+ message ); gt/ext/legend/src/org/geotools/renderer/LegendIconMaker.java: System.err.println("Topology Exception in GMLBox"); gt/demo/data/src/org/geotools/demo/data/ShapeReaderWriter.java: System.err.println("Please specify a shape file."); gt/demo/referencing/src/org/geotools/demo/referencing/TransformationConsole.java: default: System.err.println("Expected 0 or 1 argument"); return; gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.print(" ERROR! expected "); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println(expected); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.print(" ERROR! expected "); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println(expected); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println(" ERROR! intern() failed"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [s] -> [m]"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [J] -> [m/s]"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [pound/s] -> [mile/h]"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [C].pow(2)"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [F].multiply([C])"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [C].multiply([F])"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [F].divide([C])"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.err.println("ERROR: [C].divide([F])"); gt/module/main/src/org/geotools/gml/SubHandlerLinearRing.java: System.err.println( gt/module/main/src/org/geotools/gml/SubHandlerBox.java: System.err.println("Topology Exception in GMLBoxHandler"); gt/module/api/src/org/geotools/util/ProgressListener.java: * Reports a warning. This warning may be printed to the [EMAIL PROTECTED] System#err standard error gt/module/api/src/org/geotools/util/ProgressListener.java: * Reports an exception. This method may prints the stack trace to the [EMAIL PROTECTED] System#err gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: System.err.println(exception); gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: System.err.println(exception); gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: * [EMAIL PROTECTED] System#err standard error stream}). If no such [EMAIL PROTECTED] ConsoleHandler} gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: * [EMAIL PROTECTED] System#err} This handler will use a [EMAIL PROTECTED] MonolineFormatter} gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: * not possible because [EMAIL PROTECTED] ConsoleHandler#setOutputStream} close [EMAIL PROTECTED] System#err}. gt/module/referencing/src/org/geotools/resources/Arguments.java: this.err = new PrintWriter(getWriter(System.err), true); gt/module/referencing/src/org/geotools/resources/TestData.java: System.err.print(Utilities.getShortClassName(e)); gt/module/referencing/src/org/geotools/resources/TestData.java: System.err.print(": "); gt/module/referencing/src/org/geotools/resources/TestData.java: System.err.print("Can't delete "); gt/module/referencing/src/org/geotools/resources/TestData.java: System.err.println(f); gt/module/referencing/src/org/geotools/referencing/Console.java: * [EMAIL PROTECTED] System#out standard output stream}, [EMAIL PROTECTED] System#err error output stream} gt/module/referencing/src/org/geotools/referencing/Console.java: System.err.println(exception.getLocalizedMessage()); gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: * The error stream, usually the [EMAIL PROTECTED] System#err standard one}. gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: * [EMAIL PROTECTED] System#out standard output stream}, [EMAIL PROTECTED] System#err error output stream} gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: new PrintWriter(Arguments.getWriter(System.err), true), gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: * Print an exception message to the [EMAIL PROTECTED] System#err standard error stream}. gt/plugin/shapefile/src/org/geotools/data/shapefile/shp/ShapefileHeader.java: System.err.println(message); gt/plugin/shapefile/src/org/geotools/data/shapefile/shp/ShapefileHeader.java: System.err.println(message); gt/plugin/shapefile/src/org/geotools/data/shapefile/dbf/DbaseFileHeader.java: System.err.println("Could not find a field named '" + gt/plugin/epsg-wkt/src/org/geotools/referencing/crs/EPSGCRSAuthorityFactory.java: System.err.println("Could not load epsg.properties"+ oops ); gt/plugin/image/src/org/geotools/gce/image/WorldImageReader.java: System.err.println(new StringBuffer(

System.out

gt/ext/validation/src/org/geotools/validation/DefaultFeatureResults.java: System.out.println( where + ":"+ message ); gt/ext/validation/src/org/geotools/validation/relate/TempFeatureResults.java: System.out.println( where + ":"+ message ); gt/ext/validation/src/org/geotools/validation/relate/CrossesIntegrity.java: System.out.println(f1.getDefaultGeometry().getGeometryType()+" "+getGeomTypeRefA()+"("+f1.getID()+")"+" crossed "+getGeomTypeRefA()+"("+f2.getID()+"), Result was not "+expected); gt/ext/validation/src/org/geotools/validation/relate/OverlapsIntegrity.java: System.out.println("count: " + counter); gt/ext/validation/src/org/geotools/validation/relate/OverlapsIntegrity.java: System.out.println("---------------- In Overlaps Integrity ----------------"); gt/ext/validation/src/org/geotools/validation/relate/OverlapsIntegrity.java: System.out.println("########## Validation duration: " + dt); gt/ext/validation/src/org/geotools/validation/relate/OverlapsIntegrity.java: System.out.println("########## Validation errors: " + errors); gt/ext/validation/src/org/geotools/validation/spatial/LineNoSelfOverlappingValidation.java: System.out.println("***************** LineNoSelfOverlappingValidation *************"); gt/ext/validation/src/org/geotools/validation/spatial/LineNoSelfOverlappingValidation.java: System.out.println( feature.getID()+" name: "+getName() ); gt/ext/validation/src/org/geotools/validation/spatial/LineNoSelfOverlappingValidation.java: System.out.println( feature.getID()+" ref: "+getTypeRef() ); gt/ext/validation/src/org/geotools/validation/spatial/LineNoSelfOverlappingValidation.java: System.out.println( feature.getID()+" ref: "+getTypeRefs() ); gt/ext/validation/src/org/geotools/validation/spatial/LineNoSelfIntersectValidation.java: System.out.println( feature.getID()+" name: "+getName() ); gt/ext/validation/src/org/geotools/validation/spatial/LineNoSelfIntersectValidation.java: System.out.println( feature.getID()+" ref: "+getTypeRef() ); gt/ext/validation/src/org/geotools/validation/spatial/LineNoSelfIntersectValidation.java: System.out.println( feature.getID()+" ref: "+getTypeRefs() ); gt/ext/legend/src/org/geotools/gui/swing/sldeditor/symbolizer/std/DefaultTextSymbolizerEditor.java: System.out.println("Get default geometry: " + ft.getDefaultGeometry()); gt/ext/widgets-swing/src/org/geotools/gui/headless/ProgressPrinter.java: * [EMAIL PROTECTED] java.lang.System#out standard output stream}. gt/ext/widgets-swing/src/org/geotools/gui/headless/ProgressPrinter.java: this(new PrintWriter(Arguments.getWriter(System.out))); gt/ext/widgets-swing/src/org/geotools/gui/swing/tree/Trees.java: * be printed to the [EMAIL PROTECTED] System#out standard output stream} (for example) if it uses gt/ext/widgets-swing/src/org/geotools/gui/swing/tree/Trees.java: * be printed to the [EMAIL PROTECTED] System#out standard output stream} (for example) if it uses gt/ext/widgets-swing/src/org/geotools/gui/swing/tree/Trees.java: * printed to the [EMAIL PROTECTED] System#out standard output stream} (for example) if it uses gt/ext/widgets-swing/src/org/geotools/gui/swing/referencing/AuthorityCodesComboBox.java: System.out.println(((CodeList) chooser.list.getModel()).getPrototypeItem()); gt/ext/shaperenderer/src/org/geotools/renderer/shape/ShapefileRenderer.java: System.out.println("ok"); gt/ext/shape/src/org/geotools/data/shapefile/dbf/IndexedDbaseFileReader.java: System.out.println(reader.getHeader()); gt/ext/shape/src/org/geotools/data/shapefile/dbf/IndexedDbaseFileReader.java: System.out.println(++r + "," + java.util.Arrays.asList(reader.readEntry())); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("File extension must be '.shp'"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.print("Indexing "); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println(); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.print(cnt + " features indexed "); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("in " + (System.currentTimeMillis() - start) gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println(); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("Usage: ShapeFileIndexer " gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println(); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("Options:"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("\t-t Index type: RTREE or QUADTREE"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println(); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("Following options apllies only to RTREE:"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("\t-M maximum number of entries per node"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("\t-m minimum number of entries per node"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("\t-s split algorithm to use"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println(); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("Following options apllies only to QUADTREE:"); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.println("\t-b byte order to use: NL = LSB; " gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.print('.'); gt/ext/shape/src/org/geotools/data/shapefile/indexed/ShapeFileIndexer.java: System.out.print('.'); gt/ext/graph/src/org/geotools/graph/util/ParseErrorHandler.java: System.out.println(e.getMessage()); gt/ext/graph/src/org/geotools/graph/util/PriorityQueue.java: System.out.println(); gt/ext/graph/src/org/geotools/graph/util/PriorityQueue.java: System.out.println(); gt/ext/pickle/src/org/geotools/data/pickle/PickleDataStore.java: System.out.println( "write over:"+ oldFeatures.size() ); gt/module/migrate/src/org/geotools/renderer/j2d/MouseCoordinateFormat.java: * The [EMAIL PROTECTED] #getCoordinateSystem output coordinate system} may have an arbitrary gt/module/migrate/src/org/geotools/renderer/geom/PolygonAssembler.java: * &nbsp; System.out.println([EMAIL PROTECTED] #pathLine}); gt/module/migrate/src/org/geotools/renderer/geom/Polyline.java: if (out == null) out = Arguments.getWriter(System.out); gt/module/migrate/src/org/geotools/gui/swing/worker/BlockingSwingWorker.java: System.out.println("SwingWorker error" + e); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(message); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(Utilities.spaces(30-message.length())); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(' '); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(converted); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(message); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(Utilities.spaces(30-message.length())); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(' '); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(unit); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(Utilities.spaces(10-unit.toString().length())); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(' '); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(check); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(transform); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(" 38 ==> "); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(transform.convert(38)); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(transform); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.print(" 27 ==> "); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(transform.convert(27)); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println("Checking exceptions:"); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println(e.getMessage()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println("pool.size= "+Prefix.pool.size()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.println("pool.size= "+Prefix.pool.size()); gt/module/legacy/src/org/geotools/units/UnitSet.java: System.out.flush(); gt/module/legacy/src/org/geotools/cs/Ellipsoid.java: System.out.println( WGS84 ); gt/module/legacy/src/org/geotools/gp/GradientMagnitudeOperation.java: System.out.print("factor= "); System.out.println(factor); gt/module/legacy/src/org/geotools/gp/GradientMagnitudeOperation.java: System.out.print("scaleMask1= "); System.out.println(scaleMask1); gt/module/legacy/src/org/geotools/gp/GradientMagnitudeOperation.java: System.out.print("scaleMask1= "); System.out.println(scaleMask2); gt/module/render/src/org/geotools/renderer/lite/StyledShapePainter.java: System.out.println(event +" "+pt[0]+","+pt[1]); gt/module/render/src/org/geotools/renderer/lite/PackedLineIterator.java: System.out.println("Double!"); gt/module/render/src/org/geotools/renderer/lite/CustomGlyphRenderer.java: System.out.println("Tried to set the property " + nextName gt/module/main/src/org/geotools/feature/collection/AbstractResourceCollection.java: * System.out.println( feature.getID() ); gt/module/main/src/org/geotools/gml/TestHandler.java: System.out.println("here is the geometry: " + geometry.toString()); gt/module/main/src/org/geotools/gml/producer/FeatureTypeTransformer.java: * t.transform(type, System.out); gt/module/main/src/org/geotools/gml/producer/GeometryTransformer.java: System.out.println("got exception while writing null boundedby:"+e.getLocalizedMessage()); gt/module/main/src/org/geotools/gml/producer/FeatureTransformer.java: ioe.printStackTrace(System.out); gt/module/main/src/org/geotools/filter/parser/expr.jjt: System.out.println("Thank you."); gt/module/main/src/org/geotools/filter/parser/expr.jjt: System.out.println("Oops."); gt/module/main/src/org/geotools/filter/parser/expr.jjt: System.out.println(e.getMessage()); gt/module/main/src/org/geotools/filter/ExpressionBuilder.java: System.out.println("Expression Tester"); gt/module/main/src/org/geotools/filter/ExpressionBuilder.java: System.out.print("> "); gt/module/main/src/org/geotools/filter/ExpressionBuilder.java: t.transform(b, System.out); gt/module/main/src/org/geotools/filter/ExpressionBuilder.java: System.out.println(); gt/module/main/src/org/geotools/filter/ExpressionBuilder.java: System.out.println(ExpressionBuilder.getFormattedErrorMessage(pe, line)); gt/module/main/src/org/geotools/data/jdbc/JDBCTextFeatureWriter.java: System.out.println(sql); gt/module/main/src/org/geotools/data/jdbc/JDBCFeatureCollection.java: System.out.println("SQL: " + sql); gt/module/main/src/org/geotools/data/AbstractDataStoreTest.java: System.out.println(count + " feature:" + feature); gt/module/main/src/org/geotools/data/AbstractDataStoreTest.java: System.out.println(i + " feature:" + array[i]); gt/module/main/src/org/geotools/data/ReTypeFeatureReader.java: * System.out.println( f ); gt/module/main/modified-src/org/geotools/filter/parser/SimpleNode.java: System.out.println(toString(prefix)); gt/module/api/src/org/geotools/feature/FeatureCollection.java: * System.out.println( feature.getID() ); gt/module/api/src/org/geotools/feature/FeatureCollection.java: * System.out.println( feature.getID() ); gt/module/api/src/org/geotools/feature/FeatureCollection.java: * System.out.println( feature.getID() ); gt/module/api/src/org/geotools/data/DataStore.java: * System.out.println("We do not have write access to roads"); gt/module/api/src/org/geotools/data/collection/ResourceCollection.java: * System.out.println( feature.getID() ); gt/module/api/src/org/geotools/data/collection/ResourceCollection.java: * System.out.println( feature.getID() ); gt/module/coverage/src/org/geotools/coverage/processing/operation/GradientMagnitude.java: System.out.print("factor= "); System.out.println(factor); gt/module/coverage/src/org/geotools/coverage/processing/operation/GradientMagnitude.java: System.out.print("scaleMask1= "); System.out.println(scaleMask1); gt/module/coverage/src/org/geotools/coverage/processing/operation/GradientMagnitude.java: System.out.print("scaleMask1= "); System.out.println(scaleMask2); gt/module/coverage/src/org/geotools/coverage/processing/AbstractProcessor.java: * Dumps to the [EMAIL PROTECTED] System#out standard output stream} a list of operations for the gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: * to the [EMAIL PROTECTED] System#out standard output stream} (instead of the gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: * A [EMAIL PROTECTED] ConsoleHandler} sending output to [EMAIL PROTECTED] System#out} instead of gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: super(System.out, formatter); gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: super(System.out, formatter); gt/module/referencing/src/org/geotools/util/MonolineFormatter.java: * close [EMAIL PROTECTED] System#out}. gt/module/referencing/src/org/geotools/math/Polynom.java: System.out.println(roots[i]); gt/module/referencing/src/org/geotools/math/Statistics.java: * System.out.println(stats); gt/module/referencing/src/org/geotools/resources/Arguments.java: out = new PrintWriter(new OutputStreamWriter(System.out, encoding), true); gt/module/referencing/src/org/geotools/resources/Arguments.java: out = new PrintWriter(System.out, true); gt/module/referencing/src/org/geotools/parameter/ParameterWriter.java: * [EMAIL PROTECTED] System#out default output stream}. gt/module/referencing/src/org/geotools/parameter/ParameterWriter.java: this(Arguments.getWriter(System.out)); gt/module/referencing/src/org/geotools/parameter/ParameterWriter.java: * [EMAIL PROTECTED] System#out default output stream}. gt/module/referencing/src/org/geotools/parameter/ParameterWriter.java: * [EMAIL PROTECTED] System#out default output stream}. gt/module/referencing/src/org/geotools/parameter/ParameterWriter.java: * [EMAIL PROTECTED] System#out default output stream}. gt/module/referencing/src/org/geotools/nature/SunRelativePosition.java: System.out.print("Date (UTC): "); System.out.println(format.format(time)); gt/module/referencing/src/org/geotools/nature/SunRelativePosition.java: System.out.print("Longitude: "); System.out.println(longitude); gt/module/referencing/src/org/geotools/nature/SunRelativePosition.java: System.out.print("Latitude: "); System.out.println(latitude); gt/module/referencing/src/org/geotools/nature/SunRelativePosition.java: System.out.print("Elevation: "); System.out.println(calculator.getElevation()); gt/module/referencing/src/org/geotools/nature/SunRelativePosition.java: System.out.print("Azimuth: "); System.out.println(calculator.getAzimuth()); gt/module/referencing/src/org/geotools/nature/SunRelativePosition.java: System.out.print("Noon date: "); System.out.println(format.format(calculator.getNoonDate())); gt/module/referencing/src/org/geotools/nature/Calendar.java: System.out.print("Date (UTC) : "); System.out.println(format.format(time)); gt/module/referencing/src/org/geotools/nature/Calendar.java: System.out.print("Tropical year: "); System.out.println(tropicalYearLength(time)); gt/module/referencing/src/org/geotools/nature/Calendar.java: System.out.print("Synodic month: "); System.out.println(synodicMonthLength(time)); gt/module/referencing/src/org/geotools/referencing/Console.java: * and results are sent to the [EMAIL PROTECTED] System#out standard output stream}. gt/module/referencing/src/org/geotools/referencing/Console.java: * [EMAIL PROTECTED] System#out standard output stream}, [EMAIL PROTECTED] System#err error output stream} gt/module/referencing/src/org/geotools/referencing/operation/transform/LocalizationGridTransform2D.java: final java.io.PrintStream out = System.out; gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: * results sent to the [EMAIL PROTECTED] System#out standard output stream}, but those streams can gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: * The output stream, usually the [EMAIL PROTECTED] System#out standard one}. gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: * [EMAIL PROTECTED] System#out standard output stream}, [EMAIL PROTECTED] System#err error output stream} gt/module/referencing/src/org/geotools/referencing/wkt/AbstractConsole.java: this(parser, in, Arguments.getWriter(System.out), gt/module/referencing/src/org/geotools/referencing/wkt/Parser.java: * reformat them to the [EMAIL PROTECTED] System#out standard output stream}. The gt/module/referencing/src/org/geotools/io/NumberedLineWriter.java: * A default numbered line writer to the [EMAIL PROTECTED] System#out standard output stream}. gt/module/referencing/src/org/geotools/io/NumberedLineWriter.java: new PrintWriter(new Uncloseable(Arguments.getWriter(System.out)), true); gt/module/referencing/src/org/geotools/io/NumberedLineWriter.java: * [EMAIL PROTECTED] System#out standard output stream}. gt/module/referencing/src/org/geotools/io/EchoWriter.java: * Creates a writer that will echo to the [EMAIL PROTECTED] System#out standard output}. gt/module/referencing/src/org/geotools/io/EchoWriter.java: * if the echo stream is the [EMAIL PROTECTED] System#out standard output}), gt/module/referencing/src/org/geotools/io/TableWriter.java: * TableWriter out = new TableWriter(new OutputStreamWriter(System.out), 3); gt/module/referencing/src/org/geotools/io/TableWriter.java: * <code>OutputStreamWriter(System.out,&nbsp;"Cp437")</code>). gt/plugin/geometryless/src/org/geotools/filter/SQLEncoderLocationsXY.java.bak: System.out.println("exporting GeometryFilter"); gt/plugin/geometryless/src/org/geotools/filter/SQLEncoderBBOX.java: System.out.println("exporting GeometryFilter"); gt/plugin/geometryless/src/org/geotools/filter/SQLEncoderLocationsXY.java: System.out.println("exporting GeometryFilter"); gt/plugin/shapefile/src/org/geotools/data/shapefile/shp/ShapefileReader.java: System.out.println(reader.getHeader()); gt/plugin/shapefile/src/org/geotools/data/shapefile/shp/ShapefileReader.java: System.out.println(reader.nextRecord().shape()); gt/plugin/shapefile/src/org/geotools/data/shapefile/shp/ShapefileHeader.java: System.out.println(ShapefileReader.readHeader(new FileInputStream(new File(args[0])).getChannel(),true)); gt/plugin/shapefile/src/org/geotools/data/shapefile/shp/PolygonHandler.java: * removed System.out print statements gt/plugin/shapefile/src/org/geotools/data/shapefile/dbf/DbaseFileWriter.java: System.out.println(i + " : " + header.getFieldName(i)+" value = "+fieldString+""); gt/plugin/shapefile/src/org/geotools/data/shapefile/dbf/DbaseFileReader.java: System.out.println(reader.getHeader()); gt/plugin/shapefile/src/org/geotools/data/shapefile/dbf/DbaseFileReader.java: System.out.println(++r + "," gt/plugin/shapefile/src/org/geotools/data/shapefile/ShapefileDataStore.java: System.out.println("found metadata = " + xmlURL); gt/plugin/shapefile/src/org/geotools/data/shapefile/ShapefileDataStore.java: System.out.println("parsed ..." + xmlURL); gt/plugin/db2/src/org/geotools/data/db2/DB2FeatureSource.java: System.out.println(e); gt/plugin/mysql/src/org/geotools/filter/SQLEncoderMySQL.java: System.out.println("exporting GeometryFilter"); gt/plugin/mysql/src/org/geotools/data/mysql/MysqlConnection.java: return new PrintWriter(System.out); gt/plugin/oraclespatial/src/org/geotools/data/oracle/OracleDataStore.java: System.out.println( datum.getClass() ); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.println("subCoordArray.length = " + subCoordArray.length); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.println("subCoordArray: "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print("X "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print(subCoordArray[0][p] + " "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print("\nY "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print(subCoordArray[1][p] + " "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.println(""); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.println("subAttributeArray.length = " gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.println("subAttributeArray: "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print("Z "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print(subAttributeArray[0][p] + " "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print("\nT "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.print(subAttributeArray[1][p] + " "); gt/plugin/oraclespatial/src/org/geotools/data/oracle/sdo/Coordinates.java: System.out.println(""); gt/plugin/hsql/src/org/geotools/filter/SQLEncoderHsql.java: System.out.println("exporting GeometryFilter"); gt/plugin/hsql/src/org/geotools/data/hsql/HsqlConnection.java: return new PrintWriter(System.out); gt/plugin/hsql/src/org/geotools/data/hsql/HsqlDataStore.java: System.out.println("Attempted to re-create typeTable table...OK"); gt/plugin/vpf/src/org/geotools/data/vpf/util/EdgeData.java: System.out.println( "DYNGE I TRIPLETGENERERING!!!" ); gt/plugin/vpf/src/org/geotools/data/vpf/io/TripletId.java: System.out.println("Tripled id size decoding error"); gt/plugin/vpf/src/org/geotools/data/vpf/io/TripletId.java: System.out.println("tripled definition: " + definition); gt/plugin/vpf/src/org/geotools/data/vpf/io/TripletId.java: System.out.println("piece 0: " + pieces[0]); gt/plugin/vpf/src/org/geotools/data/vpf/io/TripletId.java: System.out.println("piece 1: " + pieces[1]); gt/plugin/vpf/src/org/geotools/data/vpf/io/TripletId.java: System.out.println("piece 2: " + pieces[2]); gt/plugin/vpf/src/org/geotools/data/vpf/io/VPFInputStream.java: System.out.println(msg); gt/plugin/vpf/src/org/geotools/data/vpf/io/TableInputStream.java: System.out.println("Put valid file name as parameter."); gt/plugin/vpf/src/org/geotools/data/vpf/io/TableInputStream.java: System.out.println(tcd.getName() + "=" + gt/plugin/postgis/src/org/geotools/data/postgis/PostgisDataStore.java: System.out.println(statementSQL.toString()); gt/plugin/postgis/src/org/geotools/data/postgis/PostgisDataStore.java: System.out.println(s); gt/plugin/postgis/src/org/geotools/data/postgis/PostgisDataStore.java: System.out.println(statementSQL); gt/plugin/postgis/src/org/geotools/data/postgis/PostgisDataStore.java: System.out.println("Error: " + geomAttribute.getName() gt/plugin/postgis/src/org/geotools/data/postgis/PostgisDataStore.java: System.out.println(s); gt/plugin/postgis/src/org/geotools/data/postgis/attributeio/PgWKBAttributeIO.java: System.out.println(i + " " + md.getColumnName(i) + " " + md.getColumnTypeName(i));

John Grange
Senior Software Engineer
Tel: +44 (0)1749 834922
email: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
BlueFinger Limited
Underwood Business Park
Wookey Hole Road, WELLS. BA5 1AF
Tel: +44 (0)1749 834900
Fax: +44 (0)1749 834901
web: www.bluefinger.com
Company Reg No: 4209395 Underwood Business Park, Wookey Hole Road, Wells, Somerset BA5 1AF. *** This E-mail contains confidential information for the addressee only. If you are not the intended recipient, please notify us immediately. You should not use, disclose, distribute or copy this communication if received in error. No binding contract will result from this e-mail until such time as a written document is signed on behalf of the company. BlueFinger Limited cannot accept responsibility for the completeness or accuracy of this message as it has been transmitted over public networks.***



-----Original Message-----
From: Chris Holmes [mailto:[EMAIL PROTECTED]
Sent: Tuesday, February 21, 2006 5:58 PM
To: John Grange
Cc: 'Brent Owens'; John Grange; [email protected]
Subject: Re: [Geotools-devel] Usage of System.out and System.err vs Logger


Cool. If you could report on where they are extensively used that would be helpful too. It is official GeoTools policy to use the logger, so any use of the System stuff is very bad. If you come up with a list I'll try to spend some spare cycles on removing them as well...

thanks,

Chris

John Grange wrote:
I'll see what I can do on my spare cycles....

-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Brent Owens
Sent: Tuesday, February 21, 2006 1:51 PM
To: John Grange
Cc: [email protected]
Subject: Re: [Geotools-devel] Usage of System.out and System.err vs Logger

Hi John,

It might take a while for the module maintainers to get around to changing the system outs to proper logging. I'm sure if you submitted the changed files to one of us with commit access, they could be rolled in easily and in a timely manner. Just at the current time there is heavy development going on with the complex feature model and I don't think many of the developers have any spare cycles to make the changes.

I thought the amount of system outs was much smaller and mostly isolated in test cases, and as such not something to worry about. But 200 is getting up there and they should be rolled into the logging system.

Thanks for bringing this to our attention.

Brent Owens
(The Open Planning Project)



John Grange wrote:

Hi,

I'm in the process of working on a J2EE project that is using geotools quite extensively. Geotools is great, but there appears to be a somewhat irritating use of System.out.print* and System.err.print* peppered throughout the code (207 and 43 occurrences respectively in the 2.2.trunk tree).

Surely, it is better to use only one logging mechanism as this can be effectively re-directed and controlled (to be fair, there are 2602 references to this in the source tree). The use of System.* completely messes up my stdout logs & causes a huge amount of unneccessary logfiles in a production system.

I would go through and alter the relevant statements, but they are peppered widely throughout the source and I do not have write access to the svn repository. I would suggest that module maintainers do this as part of the release process.

FYI, the searches I carried out are:

grep -r System.out * | grep -v test | grep -v "//" | grep -v ".svn" | grep -v spike | grep -v scripts | grep -v javadoc | grep -v demo | wc -l

grep -r System.err * | grep -v test | grep -v "//" | grep -v ".svn" | grep -v spike | grep -v scripts | wc -l

grep -r LOGGER * | grep -v Logger.getLogger
Kind regards and thanks for all the hard work,

John Grange
Senior Software Engineer
Tel: +44 (0)1749 834922
email:_ [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>_

BlueFinger Limited
Underwood Business Park
Wookey Hole Road, WELLS. BA5 1AF
Tel: +44 (0)1749 834900
Fax: +44 (0)1749 834901
web:_ www.bluefinger.com_

Company Reg No: 4209395 Underwood Business Park, Wookey Hole Road, Wells, Somerset BA5 1AF.

*** This E-mail contains confidential information for the addressee only. If you are not the intended recipient, please notify us immediately. You should not use, disclose, distribute or copy this communication if received in error. No binding contract will result

>from this e-mail until such time as a written document is signed on
behalf of the company. BlueFinger Limited cannot accept responsibility for the completeness or accuracy of this message as it has been transmitted over public networks.***



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel



--
Chris Holmes
The Open Planning Project
thoughts at: http://cholmes.wordpress.com
begin:vcard
fn:Chris Holmes
n:Holmes;Chris
org:The Open Planning Project
adr:;;377 Broadway, 11th Floor;New York;NY;10013;USA
email;internet:[EMAIL PROTECTED]
title:VP, Strategic Development
x-mozilla-html:FALSE
url:http://topp.openplans.org
version:2.1
end:vcard

Reply via email to