Thanks Pertti. I have updated all of the modules to indicate that there is an issue. I will bring it up during tomorrow's GeoTools meeting as well.

Note that I could not find anything wrong in MySQLDataStoreFactory.java

Updated the pages at:
http://docs.codehaus.org/display/GEOTOOLS/Indexed-Shapefile
http://docs.codehaus.org/display/GEOTOOLS/Main
http://docs.codehaus.org/display/GEOTOOLS/Tiger
http://docs.codehaus.org/display/GEOTOOLS/Validation

Cheers,

Richard

[EMAIL PROTECTED] wrote:
Here is a list of GPL-licensed files that we found (by searching for "
GPL" in the files):

ext\indexed-shapefile\src\org\geotools\data\shapefile\indexed\IndexedSha
pefileDataStoreFactory.java
ext\validation\src\org\geotools\validation\attributes\EqualityValidation
.java
ext\validation\src\org\geotools\validation\attributes\NullZeroValidation
.java
ext\validation\src\org\geotools\validation\attributes\RangeValidation.ja
va
ext\validation\src\org\geotools\validation\attributes\UniqueFIDValidatio
n.java
ext\validation\src\org\geotools\validation\attributes\UniquityValidation
.java
ext\validation\src\org\geotools\validation\DefaultFeatureValidation.java
ext\validation\src\org\geotools\validation\DefaultIntegrityValidation.ja
va
ext\validation\src\org\geotools\validation\dto\PlugInDTO.java
ext\validation\src\org\geotools\validation\dto\TestDTO.java
ext\validation\src\org\geotools\validation\dto\TestSuiteDTO.java
ext\validation\src\org\geotools\validation\FeatureValidation.java
ext\validation\src\org\geotools\validation\IntegrityValidation.java
ext\validation\src\org\geotools\validation\PlugIn.java
ext\validation\src\org\geotools\validation\relate\ContainsIntegrity.java
ext\validation\src\org\geotools\validation\relate\ContainsIntegrityBeanI
nfo.java
ext\validation\src\org\geotools\validation\relate\CrossesIntegrity.java
ext\validation\src\org\geotools\validation\relate\CrossesIntegrityBeanIn
fo.java
ext\validation\src\org\geotools\validation\relate\DisjointIntegrity.java
ext\validation\src\org\geotools\validation\relate\DisjointIntegrityBeanI
nfo.java
ext\validation\src\org\geotools\validation\relate\IntersectsIntegrity.ja
va
ext\validation\src\org\geotools\validation\relate\IntersectsIntegrityBea
nInfo.java
ext\validation\src\org\geotools\validation\relate\OverlapsIntegrity.java
ext\validation\src\org\geotools\validation\relate\OverlapsIntegrityBeanI
nfo.java
ext\validation\src\org\geotools\validation\relate\RelateIntegrity.java
ext\validation\src\org\geotools\validation\relate\RelateIntegrityBeanInf
o.java
ext\validation\src\org\geotools\validation\relate\RelationIntegrity.java
ext\validation\src\org\geotools\validation\relate\RelationIntegrityBeanI
nfo.java
ext\validation\src\org\geotools\validation\relate\SpatialTestCase.java
ext\validation\src\org\geotools\validation\relate\TouchesIntegrity.java
ext\validation\src\org\geotools\validation\relate\TouchesIntegrityBeanIn
fo.java
ext\validation\src\org\geotools\validation\relate\WithinIntegrity.java
ext\validation\src\org\geotools\validation\relate\WithinIntegrityBeanInf
o.java
ext\validation\src\org\geotools\validation\spatial\IsValidGeometryValida
tion.java
ext\validation\src\org\geotools\validation\spatial\LineCoveredByPolygonV
alidation.java
ext\validation\src\org\geotools\validation\spatial\LineNoSelfOverlapping
Validation.java
ext\validation\src\org\geotools\validation\spatial\LinesNotIntersectVali
dation.java
ext\validation\src\org\geotools\validation\Validation.java
ext\validation\src\org\geotools\validation\ValidationBeanInfo.java
ext\validation\src\org\geotools\validation\ValidationResults.java
ext\validation\src\org\geotools\validation\Validator.java
ext\validation\src\org\geotools\validation\xml\ArgHelper.java
ext\validation\src\org\geotools\validation\xml\ReaderUtils.java
ext\validation\src\org\geotools\validation\xml\ValidationException.java
ext\validation\src\org\geotools\validation\xml\WriterUtils.java
ext\validation\src\org\geotools\validation\xml\XMLReader.java
ext\validation\test\org\geotools\validation\attributes\NullZeroValidatio
nTest.java
ext\validation\test\org\geotools\validation\attributes\RangeFeatureValid
ationTest.java
ext\validation\test\org\geotools\validation\FeatureValidationTest.java
ext\validation\test\org\geotools\validation\IntegrityValidationTest.java
ext\validation\test\org\geotools\validation\relate\OverlapsIntegrityTest
.java
ext\validation\test\org\geotools\validation\RoadNetworkValidationResults
.java
ext\validation\test\org\geotools\validation\RoadValidationResults.java
ext\validation\test\org\geotools\validation\UniqueFIDIntegrityValidation
.java
ext\validation\test\org\geotools\validation\ValidationPlugInTester.java
ext\validation\test\org\geotools\validation\ValidationProcessorTest.java
ext\validation\test\org\geotools\validation\xml\XMLReaderTest.java
module\main\test\org\geotools\filter\TestFilterHandler.java
plugin\mysql\src\org\geotools\data\mysql\MySQLDataStoreFactory.java
Could not see anything wrong with this file.

plugin\tiger\src\org\geotools\data\tiger\TigerDataStoreFactory.java

  Pertti

-----Original Message-----
From: ext Jody Garnett [mailto:[EMAIL PROTECTED] Sent: 18 April 2006 16:20
To: Haggstrom Hans (Nokia-NET/Espoo)
Cc: geotools-devel@lists.sourceforge.net; Tapola Pertti (Nokia-NET/Espoo); Richard Gould Subject: Re: [Geotools-devel] GeoTools license information incorrect in the Wiki

[EMAIL PROTECTED] wrote:

Good timing Hans, we are in the middle of an IP review as part of our involvement with the OSGEO Foundation, it seems you have the jump on us. The project is intentended to be LGPL, commercial friendly and so on. I will go fix the SF page now, we do not really use their facilities other then for code distribution.

Any code that does not meet this will be rewritten.

Hello,

In the documentation in the GeoTools wiki the license for

GeoTools is
described as LGPL ( _http://www.geotools.org/display/GEOT/1.4+Source+License_ ).

However, on the sourceforge project page the licenses GPL, LGPL, and MIT are listed ( _http://sourceforge.net/projects/geotools/_ ).

In the sources (for version 2.1.0), there seems to be both LGPL and GPL licensed code (based on license comments in files), as

well as one
source file covered by the Sun license (NumberParser.java,

copied from
an old version of the JDK perhaps?).  The Sun license comment reads:

* Copyright 2002 Sun Microsystems, Inc. All rights reserved.
* SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.

Could the Wiki page mentioning only LGPL be updated to reflect the licenses mentioned on the sourceforge page? (Or alternatively the code updated to only contain LGPL licensed code, althought that is probably a more long term effort). Also, the Sun licensed file should probably be replaced or at least investigated, as it seems to be incompatible with GPL and LGPL.



We wanted to use the main-2.1.0.jar and shapefile-2.1.0.jar with the LGPL license. Fortunately, these two Jars did only contain one unit test file and one html file that were GPL licensed, and the Sun licensed NumberParser.java (used for parsing some doubles from strings). We removed the test, html file, and

NumberParser.java. We
had to replace the places where NumberParser.java was used (in
DbaseFileReader.java) with (slower) calls to standard JDK

library methods.

Darn shapefile was just checked by Richard, I will ask him to look into this and get back to you. Probably would not hurt to open a issue on this stuff..

According to LGPL we make our changes to the code available in the attached file (it was the only changed source file).


Thanks muchly,
Jody





-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to