Reviewed the patch. I could be missing something ( i am pretty unfamiliar with this class ) but i think the recursive call to readFidColumn on line 44 of the diff should be:
readFidColumn( index + 1 ); instead of readFidColumn( index ); So if I am not mistaken this code catches an exception that is thrown by the jdbc driver which occurs when trying to turn an oid into an integer? It seems strange to me that the jdbc driver doesn't handle this directly. Actually doing some looking it seems that others have the same issue and patch the jdbc driver accordingly. http://db.apache.org/torque/version-specific/database-howtos/postgres-howto.html I wonder why the driver doesn't map to a type with a larger value space. -Justin Cory Horner wrote: > Cory Horner (JIRA) wrote: > >> Support FID values greater than int >> ----------------------------------- >> >> Key: GEOT-958 >> URL: http://jira.codehaus.org/browse/GEOT-958 >> Project: GeoTools >> Issue Type: Improvement >> Components: core main, data >> Affects Versions: 2.3.M0, 2.2.0 >> Reporter: Cory Horner >> Fix For: 2.2.1, 2.3 >> > I've attached a patch for this issue (2.2.x). It should improve the > QueryData class to support an OID FID of type Long -- please have a look > to see if anything seems out of place: > > http://jira.codehaus.org/secure/attachment/23229/QueryData.diff > > Unfortunately this is difficult to test, but we do have one user with a > > 2B feature table who may be able to test. > > Thanks, > Cory. > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:1004,45219a3b67791410093335! > -- Justin Deoliveira [EMAIL PROTECTED] The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
