Hi Cory, The patch looks good. A couple of comments:
1. The result sets created in teh method are never closed. This was like this before I know, might be a good time to fix it. Not a big issue though. 2. The pattern matching that is done to find the sequence from the system tables. Is there any chance it could pick up the wrong sequence Like for instance if i have two columns in the same table, one named 'foo', and one named 'foobar', that both have a sequence defined on them, it might be able to pick up the sequence for foobar when searching for foo. Can we make the comparison a bit tighter? -Justin Cory Horner wrote: > Hi guys, > > Here is a patch for PostGISAutoIncrementFIDMapper which provides a > slightly more intelligent technique for mapping the FID of a non-serial > sequence, which has a higher success rate than our current code: > > http://jira.codehaus.org/browse/GEOT-953 > > I am ready to commit, although I may change SQLException to Exception. > > I have uncommitted tests which successfully demonstrate feature > insertion for 6 situations, using both PostgisFeatureWriter and > PostgisFeatureStore: > 1. serial (int4) primary key > 2. non-serial int4 primary key > 3. bigserial (int8) primary key > 4. non-serial int8 primary key > 5. serial (int4) primary key, without oids, and space in table name > 6. non-serial int4 primary key, without oids, and space in table > name/sequenceTh e > > Please review, and I will proceed. > > Cheers, > Cory. > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:1004,452414c1139811804284693! > -- Justin Deoliveira [EMAIL PROTECTED] The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
