Cool, sounds good, go ahead an apply the patch. -Justin
Cory Horner wrote: > Justin Deoliveira wrote: > >> The patch looks good. A couple of comments: >> >> 1. The result sets created in teh method are never closed. This was like >> this before I know, might be a good time to fix it. Not a big issue >> though. >> >> > done. > >> 2. The pattern matching that is done to find the sequence from the >> system tables. Is there any chance it could pick up the wrong sequence >> Like for instance if i have two columns in the same table, one named >> 'foo', and one named 'foobar', that both have a sequence defined on >> them, it might be able to pick up the sequence for foobar when searching >> for foo. Can we make the comparison a bit tighter? >> >> > Good point... the "last resort" (find the last row) method is a lot > safer than possibly getting the wrong sequence. 80% of the time we will > get a postgres generated sequence, so let's do a case-insensitive match > on "table_column_seq", rather than "%table_column%". > > Thanks! > Cory. > > !DSPAM:1004,45242866159287785049143! > -- Justin Deoliveira [EMAIL PROTECTED] The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
