Thanks (and sorry for the huge patch). 

I will try to describe the the transformation in more detail:

basically the problem is that since all the function implementations implement 
both geoapi and geotoos function interfaces, they're not synchronized in 
order to behave correctly whether one or the other is used

1- a new constructor to set the function name, since some functions, though 
extending AbstractFunctionImpl, were returning null in getName
        function_x()
                super("X");

2- new method setParameters and List getParameters
This change implies  that setArgs delegates in setParamenters to set the 
instance variable that maintains the parameters (or arguments) in a 
ArrayList; as a bunch of functions were storing the arguments by themselves 
but getArgs/getParameters and setArgs/setParameters were inconsistent

3- specific setting method to update parameters like setExpression was changed 
to taking into account the new parameters allocation (ArrayList)

4- new method evaluate()  that implements the function evaluation delegating 
in the old getValue(), as much of them did not implement evaluate.

5- Additionaly, a new test was added to assure that the new and the old 
interface go well: org.geotools.filter.FunctionExpressionImplTest

If you need any more, do not hesitate to contact me.

Thanks a lots


On Friday 18 May 2007 10:55, you wrote:
> Mauricio,
> the patches are huge, and I guess they are doing some regular
> transformation on the filters.
> I would be helpful to know that the transformation is without
> scrolling down 480kb of patch :)
> Cheers
> Andrea

-- 
Mauricio Pazos

www.axios.es
tel-:+34 94 441 63 84

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to