Jody Garnett ha scritto: > Justin Deoliveira wrote: >> If you choose the Java 5 option, could you also please vote on whether >> you would like to make the change to FeatureType (see note below). >> >> Also note that if the Java 5 route is chosen it will require that we >> release 2.4 against java 5, and not just 2.5. >> >> A. Java 5 Option: >> >> AttributeType: >> * rename "getName()" to "getLocalName()" >> * rename "getType()" to "getBinding()" >> >> Feature: >> * retype "getBounds()" to "ReferencedEnvelope" >> * rename "getDefaultGeometry()" to "getPrimaryGeometry()" >> >> FeatureType: >> * rename "getDefaultGeometry()" to "getPrimaryGeometry()" >> >> ** Note: The change on FeatureType is technically not needed with type >> narrowing, but we may wish to rename it to maintain consistency with the >> change to Feature. >> > The Java 5 option is way better :-) > > I asked previously, but perhaps it was lost, about renaming > AttributeType.getName() to AttributeType.name(). Perhaps it is a stupid > idea, I just like representing derived quantities without java bean > naming conventions...
As a matter or reading the code, not having the "get" is maybe nicer, but it would break javabeans conventions making it a lot harder to access that property thru javabeans reflection, something that many libraries allow to (think reporting, templating and so on). I'd prefer to avoid it and keep "get" in front of all properties that can be read, be them primary or derived. Besides, if the convention is primary or derived, that would be a way to expose an implementation detail to users. Many times deciding which one is the derived property is a matter of convenience, that may change over time. Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
