Justin Deoliveira wrote: > I can see the argument for bringing the parent filters down... and it > should probably be consistent with how we bring other things down from > parent types. Like properties for instance. > I would recommend adding the following methods (just not right now): - getAllRestrictions(): And - getAllProperties(): List<PropertyDescriptor>
>> * OperationType >> "exciting" should not have a place in javadocs... I guess >> this one still needs to be rewritten? >> > Yes... actually i would almost like to kill operations in that it is not > referenced from anywhere. Not kill the interface. My reasoning is that > we dont currently have a use case for them. Jody keeps mentioning some > coverage stuff... but noone really seems to be chomping at the bit for > it. So if it were up to me I would kill any reference to Operations from > the rest of the model, and add it when someone actually needs it. > We don't need any explicit reference; they show up as a PropetyDescriptor and that is it. A "invoke( Name, Object[] ) would be nice but we can leave it for later. > Now that getValue() has moved up to Property i see no reason for it > Cool one less method the better. > Yes, actually i meant to kill SimpleFeatureFactory but did not do it. > There is no gain over using it from normal FeatureFactory. > Done. > Yeah, i botched this one up big time. As Jody stated we needed this > review before 2.4-RC0 went out. My preference would be to revert the > changes on 2.4.x back to getDefaultGeometry(). > me too. > Although... as an actual releease has gone out are we too late. I mean > the chances of a tone of client code already making the switch are slim > so I think we can probably get away with it... but it would be a nono in > terms of api policy. > So far I did update the code examples by way of reviewing the 2.4-RC0. However I am using this jar in my FOSS4G course ... Jody ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
