Hi Saul, good catch.
my preference would be to get rid of the prefix as much as possible. On the bright side all the classes in the module except the datastore and gce factory implementations are to be considered private, and even those two ones are since SPI takes care for us, so we shouldn't be hurting anyone. hmm. wrong, ArcSDEDataStore and ArcGeoResource are public and uDig casts to them.. anyway, my point is that I agree naming is a bit screwed, and since we have the java package naming system to define namespaces, so there should be a good reason for a class name to use a prefix. I'm for removing the prefixes from the most possible class names, and letting them only where they make sense. It seems common practice to have the datastore and datastore factory impls named as per the backend they use, etc. Though I'm too tired now to go through the whole list and figure out what and whatnot. Yet, I guess the only ones that make sense are ArcSDEDataStoreFactory ArcSDEDataStore ArcSDEFeatureSource/Store/Locking and that should of be it. Not sure about the naming for gce stuff though, you'll know better. We can talk more on monday or you can make your own list of changes and send email, whatever fits you better. Cheers, Gabriel On Friday 04 April 2008 11:10:20 pm Jody Garnett wrote: > Saul Farber wrote: > > * I don't care one way or the other on the "ArcSDE" vs "ArcSde" thing, > > just that we do it consistently (hrm, why do I feel so anal about that? > > I'm not sure, perhaps I need therapy...). > > Think the java class naming conventions lean in favour of ArcSDE (since > SDE stands for something). > - http://java.sun.com/docs/codeconv/html/CodeConventions.doc8.html > > > Sun's naming guidelines states > > > > Class names should be nouns, in mixed case with the first letter > > of each internal word capitalized. Try to keep your class names > > simple and descriptive. Use whole words - avoid acronyms and > > abbreviations (unless the abbreviation is much more widely used > > than the long form, such as URL or HTML). > > We used to have a Jalopy setting that would give you warnings; perhaps > you can set up similar warnings for NetBeans or Eclipse? I know FindBugz > is willing to give me warnings about non standard class names. > > Jody > > > * I feel like "utility" or "helper" classes that are internal to the > > API could live without the prefix, but that all outward-facing classes > > should have the prefix. > > > > Your thoughts? > > > > --saul > > > > > > > > > > > > ------------------------------------------------------------------------- > > Check out the new SourceForge.net Marketplace. > > It's the best place to buy or sell services for > > just about anything Open Source. > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketpl > >ace _______________________________________________ > > Geotools-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:4045,47f69958186791628642973! ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
