Jody Garnett ha scritto: > Andrea Aime wrote: >> I'm not complaining about the API change per se btw, this >> seems to be covered by the raster symbolizer proposal already >> (the new visits are there to allow visitors to handle the >> raster symbolizer components that were missing, a necessary >> change in order to make raster symbolizer support work). >> What I'm worried about is more that some visitor are not >> going to work as intended when they stumble upon a raster >> symbolizer (especially the attribute extractors, used >> to limit the number of attributes loaded by the renderer, >> and the style duplicator, which most probably won't duplicate >> the raster symbolizer properly... there are various others, >> but I'm not familiar with them so I cannot comment on the >> needed changes). >> > This will be a problem we have whenever we upgrade our code to a new > specification (or in this case meet the existing one). We would be > better advised to have StyleVistior implemented as an abstract class; or > at the very least have implementations get in the habit of extending a > "StyleVisitorAdapater".
Hmm... not sure that would have been any good. The only reason I noticed that the style duplicator and the attribute duplicator had been broken was because of a compile error in geoserver, and I got that exactly because we don't extend a base class. The base class would just hide these errors, just like the mock implementations of those methods are. I prefer to stand up the errors and fix them instead of hiding them below the carpet. Just my 2 cents Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
