Hi,
since a few days the GeoServer build is broken due to a compile
problem. The compile problem originates in an API change in the
StyleVisitor interface.
I looked into it. GeoTools has many many of such visitors,
various of them used for things as style attribute extraction
or style duplication. All of these have been "fixed" by making
them implement the new 6 methods as stubs, that is, as empty
methods. Needless to say, this may make compiler and tests
happy, but breaks the intended behaviour of those visitors.
In GeoServer we have the palette extractor that has not
been fixed in this way, and thus does not compile. I'm fixing
it as I type, but I'm wondering, who's going to fix all
the gt2 visitors whose intent has been broken by that
"make compiler happy" change?
I'm not complaining about the API change per se btw, this
seems to be covered by the raster symbolizer proposal already
(the new visits are there to allow visitors to handle the
raster symbolizer components that were missing, a necessary
change in order to make raster symbolizer support work).
What I'm worried about is more that some visitor are not
going to work as intended when they stumble upon a raster
symbolizer (especially the attribute extractors, used
to limit the number of attributes loaded by the renderer,
and the style duplicator, which most probably won't duplicate
the raster symbolizer properly... there are various others,
but I'm not familiar with them so I cannot comment on the
needed changes).
I opened two jira issues to handle this one, one to make
sure the changes to restore proper behaviour of visitors
will be performed, the other to make sure the documentation
will be updated in order to remind users of the API change
("upgrade to gt2 x.y" documents):
http://jira.codehaus.org/browse/GEOT-1788
http://jira.codehaus.org/browse/GEOT-1789
Cheers
Andrea
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
