Andrea Aime wrote:
> Soo, long story short, no, I'm not seeing anything we could reuse
> on 2.4.x there. Soo, what do we do? Add the following to SQLBuilder
> interface?
>
> interface SQLBuilder {
> public String encode(Expression)
> public String encode(Filter)
> }
Sounds good; if you look at the interface SQLBuilder you will see the
setHints method; this is how FEATURE_2D and FEATURE_DETACHED get added
into the mix....
> and change SQLEncoder and FilteToSQL so that they do expose a
> encode(Expression) and an encode(Filter, boolean wherePrefix)
> methods, the latter used to get a filter encoded without
> the "WHERE" prefix? Or can just do some string manipulation
> in SQLBuilder implementation and get rid of it.
>
> Now, SQLBuilder is public api, yet it's not that "public", in
> a sense that the SQLBuilder class was not meant to be user
> facing. Shall I roll a very quick proposal?
Gak; JDBCDataStore is not really public either this is kind of a border
line gray area ... wait.
I think I lost sight of your original problem...
The aggregate functions are sent in as a FeatureVisitor to the
FeatureCollection produced by the JDBCDataStore; as such it can be
intercepted in its entirety the correct SQL generated and sent off ...
all without making any user facing public api.
Jody
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
