Jody Garnett ha scritto: ... >> Now, SQLBuilder is public api, yet it's not that "public", in >> a sense that the SQLBuilder class was not meant to be user >> facing. Shall I roll a very quick proposal? > Gak; JDBCDataStore is not really public either this is kind of a border > line gray area ... wait. > > I think I lost sight of your original problem... > > The aggregate functions are sent in as a FeatureVisitor to the > FeatureCollection produced by the JDBCDataStore; as such it can be > intercepted in its entirety the correct SQL generated and sent off ... > all without making any user facing public api.
Intercepted? Eh? How? FeatureVisitor is already being replaced completely by a sql query, but that's exactly where the problem is, the sql buildling is broken (and thus the need to make it right by using some new SqlBuilder functionality). Of course one could subclass JDBCFeatureCollection and repeat the same damned code all over the place for each different dbms, but that would require even bigger changes on the code (not the API, but for the code, yes, quite a bit). Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
