On Wed, 2008-07-02 at 01:10 +0200, Jody Garnett wrote: > Andrea Aime wrote: > >> The duplication of method names results in hard to understand code. > >> Here is the suggested improvement: > >> - FeatureType.getAttributeDescriptor(): AttributeDescriptor > >> - Feature.getAttribute(): Attribute > > Yes, I like the proposed solution better. I believe the original > > method names were shortened to save space. > I just had a go at changing this; but then it was hard to stop; ie we > should have getAttributeDescriptors() and getPropertyDescriptors() and > so on ... so I backed out my change. I need some kind of "heck yeah" > from the usual crowd of people who care about this stuff? >
HECK YEAH! Please! If we can do this before 2.5 it will simplify the life of everyone over the next two years. (but see below) > Acuster ping? what are your thoughts? Is this worth the trouble now? > Will it save us enough trouble later? I think Landon was also interested > in this inconsistency? Note, I don't mind if the method name doesn't match the return value, I mind when the method name matches some other value which is not at all what is returned. So, getIceCream() : AttributeDescriptor is ok getFeature() : AttributeDescriptor is annoying, bad, mean I'm not asking for alignment, I'm asking to make sure we are not misaligned. Perhaps all these could simply be: getDescriptor() and the kind of Descriptor would be clear from the context of the object on which the method is called? --adrian > > Jody > PS. Andrea it will be better to load GeoAPI and GeoTools and GeoServer > into the same workspace and use "refactor" to accomplish this rename. > > ------------------------------------------------------------------------- > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > Studies have shown that voting for your favorite open source project, > along with a healthy diet, reduces your potential for chronic lameness > and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
