Jody Garnett wrote: > We need to talk to the project steering committee on this one (in > tomorrows IRC meeting?) since we are talking about changing the build > system. > I am way on a training course and cannot attend ... can you either > attend; or we can start up a vote on email here.
Voting here is good for me (UTC+8). > The reason for the connection() not being considered fatal is because > sometimes servers are down; in the past we had the build fail when ever > some random server on the Internet is busted - which was not cool. > As I understand it you expecting people that run online tests to provide > their own fixtures; and thus it there own problem if the server is down? > For me I am thinking about the various WMS Servers that we run against; > these ones are not controlled by a fixture file (and I do not want the > build broken if I can simply not connect). OnlineTestCase does not discriminate between a server being down and defective code. Tests should document what is required to setup an online test, and it should be minimal. The case I have is for JDBC data stores. For JDBC tests, testers will have to set up their own databases. I had not thought about tests consuming public WMS. I can see the problem. > So it looks like we are trying to handle two forms of online tests? Yes. OnlineTestCase is a class that does too much. We need to separate out the two functional parts: (1) Turning on a test if a fixture property file is present. (2) Failing silently (ie. a false unit test pass) if the service cannot be contacted. Perhaps either: (1) an isServiceAvailable() method that subclasses can implement to see if the test should be skipped, or (2) a subclass EasilyDisheartenedOnlineTestCase that gives up silently if connect() fails. -- Ben Caradoc-Davies <[EMAIL PROTECTED]> Software Engineer, CSIRO Exploration and Mining Australian Resources Research Centre 26 Dick Perry Ave, Kensington WA 6151, Australia ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
