Ben Caradoc-Davies wrote: > Jody Garnett wrote: >> We need to talk to the project steering committee on this one (in >> tomorrows IRC meeting?) since we are talking about changing the build >> system. >> I am way on a training course and cannot attend ... can you either >> attend; or we can start up a vote on email here. > Voting here is good for me (UTC+8). We need to have something to vote on - ie a policy change on the handling of online tests. The result should be a change to the developers guide (and possibly some fixes to the OnlineTestCase base class? > Yes. OnlineTestCase is a class that does too much. > > We need to separate out the two functional parts: > (1) Turning on a test if a fixture property file is present. > (2) Failing silently (ie. a false unit test pass) if the service > cannot be contacted. > > Perhaps either: > (1) an isServiceAvailable() method that subclasses can implement to > see if the test should be skipped, or > (2) a subclass EasilyDisheartenedOnlineTestCase that gives up silently > if connect() fails. I like the Subclass option *much* better; it will be easier to document and understand. So can we come up with a better name? What makes it special for me is that it has a Fixture; for a lot of the other "online" tests the fixture acts as an override ...
So how about: - OnlineTestCase - super class to use when testing against an online server like www.refractions.net for PostGIS. These tests are only there to test conformance (so if the server is down the test cannot be run; and it is not worth annoying developers with failure). - FixtureTestCase - super class to use that offers a test fixture configured based on settings stored in the home directory. These tests are there to abuse a local database or webserver and basically represent test cases that require a server to run. Jody ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
