Justin Deoliveira wrote: > I would be fine with this. Good work Christian!! I probably won't be > releasing 2.5 until next week anyways, since I hope to get GeoServer > 1.7.0-RC3 out first, so there is time to do the move and get the > module in. > > Jody, what do you think? I believe all the criteria has been met? Here is the checklist: - http://docs.codehaus.org/display/GEOT/Supporting+your+module
I was unable to verify the first entry on the checklist... so some work is needed. > Christian Müller wrote: >> I have done the following to meet the requirements: >> 1) The documentation is in the WIKI (including documentation for the >> import utility, for the ddl generation utility, >> and hints for all supported databases) >> http://docs.codehaus.org/display/GEOTOOLS/Image+Mosaicing+Pyramidal+JDBC+Plu >> gin >> This page should be integrated in the official guides, who is >> responsible for that ?. A link on the module matrix page is also needed. I have moved your page to the user guide: - http://docs.codehaus.org/display/GEOTDOC/Image+Mosaicing+Pyramidal+JDBC+Plugin Please note that your page actually covers some design and approach issues that may be best described on your module matrix page (along with module status, future plans and the like). The user guide is mostly focused on how to use the end product. >> 2) Test >> The plugin has only one official API >> ImageMosaicJDBCReadr>>read >> which results in a GridCoverage. The normal build executes 24 tests >> using the h2 db. >> There are 20 Online test for postigs,oracle,db2 and mysql. The test >> results are images stored in the target directory >> A full test run including all online tests does 104 tests. I would like to see the test coverage (ie run mvn site and look at the test coverage report). It is not the number of tests but how well the tests explore al the pathways in the code... Here is shapefile as an example: - http://maven.geotools.fr/reports/modules/plugin/shapefile/clover/index.html You can see that it has 58% test coverage (the bug number at the top of the page). I have updated the "Supporting your module" page with the above information - since it was apparently not clear to you. I would also recommend running Find Bugs on your module (that is the first thing I do in a code review these days). >> 3) Of course, I will be the module maintainer doing the support and >> fixing bugs That is good to know; if you can provide your contact information (or simply instructions to ask questions on the user list) at the top of your module matrics page it will be good. >> 4) As you know already, the plugin is already deployed twice in >> production environments (Geoserver and Websphere EJB Container). >> Anything missing ? Several things; but you can go through the checklist and get back to us. It does sound like you have some time before Justin makes the 2.5.0 release; however please do not rush on our account - we can always make a 2.5.1 release that includes your module when you are ready. Cheers, Jody ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
