On Sunday 30 November 2008 00:19:00 Jody Garnett wrote: > Gabriel Roldán wrote: > > Hey Jody, > > > > I know you may be full of work, but if you have a chance it'd be great if > > you could take a look at my comments on > > http://jira.codehaus.org/browse/GEOT-1637 > > Commented ; you are correct that argument count is not supposed to > matter and need not be checked. If the function implementation wants to > handle more (or less?) arguments it can do so - or throw an error message. > > There is however one *very* interesting wrinkle; Functions can now have > a fallback value allow the "split" to be evaluated even if the function > is not supported - I think it would be good to handle this as a separate > visitor (or as a constructor argument to the visitor.
If I'm getting it right, this means the runtime evaluation of the function will default to the fallback value if not natively supported by the datastore? If that's the case there might not be a need for anything special, if the datastore supports a given function with fallback value then its FilterCapabilities should contain it, otherwise it's going to end up on the unsupported bag and hence a target for runtime evaluation? but it seems I'm getting it wrong uh? > > Actually I am *not* full of work and that is a trouble ;-) So I am > writing up quotes and stuff trying to get work (sigh!). However Sydney > is beautiful and it is spring time so life is good. gah, so enjoy since you know everything will turn out to be just fine :) cheers, Gabriel > > > I have ported PostPreProcessFilterSplittingVisitor to use Capabilities > > instead of the deprecated geotools FilterCapabilities and would need to > > move it to main so I can use it on arcsde too. > > That sounds great - I assume you have been talking this over with Andrea > right? > > > Also it'd be good for the jdbc datastores to make the move to geoapi > > FilterCapabilities and hence be closer to getting fully rid of the old > > filter stuff. > > Correct of course. I talked with Andrea just as I was leaving Canada and > he was starting to remove the old Filter stuff; and he wanted to stay > focused on that rather than the capabilities side of things. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
