Gabriel Roldán wrote:
> understood.
> But since my first goal was to port what currently is on  
> PostPreProcessFilterSplittingVisitor to non deprecated stuff what if I move 
> it to main so we can look at what's needed for fallback values on actual code?
>   
Good plan; get onto non deprecated code first and then we can look at 
fallback value as we find it; I only mentioned fallback value as it was 
part of the change
that gave you variable number of arguments (ie your origional question).
> For doing so, tough, I have a naming clash. Should I call the non deprecated 
> one PostPreProcessFilterSplittingVisitor2 or something?
>   
Can we find anything shorter? That is a real moth full...

SplitLocalVisitor - result in filter that can be executed on the local 
implementation (ie the capabilities of geotools)
SplitRemoteVisitor - result in filter that can be executed on the remote 
service (ie the capabilities of the datastore) (using fallback values if 
needed based on capabilities function list)
BiSplitUsingCapabilitiesVisitor - result in two filters (one for local 
and one for remote) that applied together would be the same as the 
origional filter

> the other way around would be to just overload the current 
> PostPreProcessFilterSplittingVisitor constructor with a Capabilities and make 
> the appropriate forks inside depending on whether it was fed with a geotools 
> FitlerCapabilities (deprecated) or a Capabilities (non deprecated), and 
> maintain both sets of unit tests while we don't remove the deprecated bits.
>   
That sounds a bit magic to me; and I always tripped up over the really 
long name.

Jody

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to