Hi Andrea - I am looking forward to this one (and we can make it the default in uDig trunk so it gets some eyeball time in front of developers - we actually have a code sprint coming up and are releasing an alpha to generate bugs reports leading up to it).
I am getting a bit tired of active words in package names "renderer" and "labeler" ... making a "renderer.labler" hyper active? so for package org.geotools.renderer.label would be fine. LabelCacheImpl would copy what the other implementations are doing; but you are correct these classes are not really going to be public facing (so remove the prefix). There is one annoying bit of work that I would like to request - even if you can just tell me how to do it. Jesse started to look into this one but got busy. In uDig we have a problem with labels "floating to the top" and appearing over top over other map graphics like scalebars and legends. I would like a method to to be able to "reserve" an rectangle on the screen and let the labeller know that it is already full up. Jody Andrea Aime wrote: > Hi, > > so I'm looking into the details of contributing the > improved labeller I've developed for GeoServer > back to GeoTools. > > The new one is split into five classes (compared > to the two of the current one) so it would be better > to allocate a package for it. > > What about org.geotools.renderer.labeller? > Or org.geotools.renderer.lite.labeller? > > I'm also wondering about the class named. Atm > the classes are named: > - GSLabelCache (the main class, groups the labels, > locates the label position with the help of the rest) > - GSLabelItem (holds the informations about a single > label) > - LabelIndex (spatial index of the labels drawn so far) > - LineStringCursor (helps walking along a linestring) > - GSLabelPainter (actually draws the label, either > straight or curved) > > Of course GS* is not a good naming. Any sort of > New* Advanced* *NG is going to become incorrect > in a matter of months (when something else might > become "new"). > > So what about just calling it again LabelCacheDefault? > Or better, DefaultLabelCache? The different package > will avoid naming clashes. > For the other GS* classes I'd suggest to just remove > the prefix. > > How does this sound? Let me know. > > Cheers > Andrea > > ------------------------------------------------------------------------------ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
