Ben Caradoc-Davies wrote: > Justin Deoliveira wrote: >> Ben Caradoc-Davies wrote: >>> I will also reformat the affected files as a separate commit. >> Is the reformat necessary? Formatting makes it quite hard to apply >> patches to multiple branches. > > There is crazy inconsistent indentation in many places, including mixing > spaces and tabs. The source is a mess. Normally I avoid reformatting > because of the spurious diffs it causes, but this is getting nasty. > > Would a less aggressive indentation fixing (Eclipse: Ctrl-A Ctrl-I) be > OK? This is my trusty fallback when working on badly-formatted code. Or > is this just as bad for branch maintenance? As a non-branch-maintainer I > have the luxury of being able to fix things. :-) > > If you prefer, I can just leave it alone. The compiler reads it a lot > more than I do.
Jody, as module maintainer, please indicate your preference for how the bad formatting in these files (ComplexTypeImpl, FeatureTypeImpl, SimpleFeatureTypeImpl) should be handled: (1) Eclipse reformat to GeoTools conventions. (2) Eclipse fix indentation (Ctrl-A Ctrl-I). (3) Do nothing. Kind regards, -- Ben Caradoc-Davies <ben.caradoc-dav...@csiro.au> Software Engineer, CSIRO Exploration and Mining Australian Resources Research Centre 26 Dick Perry Ave, Kensington WA 6151, Australia ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
