Style Cleanup
-------------
Key: GEOT-2692
URL: http://jira.codehaus.org/browse/GEOT-2692
Project: GeoTools
Issue Type: Improvement
Components: core styling
Reporter: Jody Garnett
Creating a separate bug report for style clean up (so GEOT-2532 can be closed
in peace). The Style classes are been collecting a lot of cruft and it is very
hard to make use of them without tripping over deprecated methods.
The major goal is:
- go through the style classes and ensure the new stuff from Symbology Encoding
are accounted for with getter and setter methods in the geotools code base that
explicitly type narrow to geotools interfaces
A couple of stops along the way - so we can know the above is done and working:
- A non public "cast" method allowing the style implementation classes to
convert an org.opengis.style class into a geotools implementation with setter
methods
- Implement StyleFactoryImpl2 as a "clean" implementation of an
org.opengis.style.StyleFactory ensuring all our setter methods are working etc
- StyleFactoryImpl maintain an internal StyleFactory2 in order to implement
org.opengis.style.StyleFactory
- Complete andrea's StyleBuilder concept - making sure it can handle the new
stuff (this is what started me looking at the missing setter methods)
- It is my intension to only use StyleFactoryImpl2 from StyleBuilder code
I have noticed that there are some helper subclasses in the geotools code base;
that should be deprecated and later removed. These classes are interesting in
that they subclass StyleImpl directly:
- BasicLineStyle
- BasicPolygonStyle
Open Questions:
- I am also unsure if we should break appart SLDParser into an SEParser or just
abuse the flexible nature of this DOM parser to allow it to handle either.
- The functions defined by Symbology Encoding are very tied to the
RasterSymbolizer - indeed they replace the ColorMapEntry model... a couple of
them are implemented in the Renderer module and may need to be moved over and
completed if we are to reply on them for RasterSymbolizer work.
- A StyleVisitor that can remove default values would be very handy in cutting
down on the size of the SLD files we produce
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
