That's looking good, I know it's being hard so congrats on the 
achievements..
> 
> 2) How should complex types with simple content be represented? Jody has 
> said/suggested that this be a property with the name "value", which is 
> marked as inline. I think that can work... there will just have to be a 
> another special case in the encoding logic which will use the "value" 
> property when it detects the complex type simple content case.
> 
> However the feature model is incomplete in this regard. 
> ComplexAttribute.isInline() is never set (there is no way to set it) and 
> it always returns false.

The approach makes perfect sense. Just a thought though, by the javadocs 
of ComplexType.isInline() I'm not getting a full sense of why it does 
match the case of hiding the "value" property and not the other ones...
I don't think that inline property was ever used and I question if it's 
sole purpose is to flatten a tree structure for performance reasons?

  I wonder if "complex type with simple content" does not deserve its 
own ComplexType subclass:
interface InlineComplexType extends ComplexType{
        AttributeDescriptor getInlineValueDescriptor();
}

To me, that seems to fit better with the current practice of the "typing 
system" (like in FeatureType.getGeometryDescriptor()). InlineComplexType 
is still a ComplexType in all its nature and you can code in a strongly 
typed way (like for the bindings) instead of using isInline to decide 
what to do everytime you get a ComplexAttribute.

thoughts?

Cheers,
Gabriel

> 
> 3) Sync up with Ben on the generic complex attribute binding, as I know 
> there are bits of this logic already in place.
> 
> -Justin
> 
> 


-- 
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to