>> However the feature model is incomplete in this regard.
>> ComplexAttribute.isInline() is never set (there is no way to set
>> it) and
>> it always returns false.
Yeah I am aware of the limitations; and that is why I am wanting
feedback and a review
as we roll this one out.
>
> The approach makes perfect sense. Just a thought though, by the
> javadocs
> of ComplexType.isInline() I'm not getting a full sense of why it does
> match the case of hiding the "value" property and not the other
> ones...
See other email; I think "isInline" may be in the wrong spot; I think
it may need to move
to PropertyDescriptor? The original intent was to handle "choice" and
repeating
ordered groups of elements while still offering a clean UML friendly
breakdown.
> I don't think that inline property was ever used and I question if
> it's
> sole purpose is to flatten a tree structure for performance reasons?
Ben identified this issue of extending a simple type as a new
requirement; and we discussed the
approach but this is the first I have heard back of it not working. In
trying to put together a code example
for Justin I think I have identified where the problem is...
>
> I wonder if "complex type with simple content" does not deserve its
> own ComplexType subclass:
> interface InlineComplexType extends ComplexType{
> AttributeDescriptor getInlineValueDescriptor();
> }
>
> To me, that seems to fit better with the current practice of the
> "typing
> system" (like in FeatureType.getGeometryDescriptor()).
> InlineComplexType
> is still a ComplexType in all its nature and you can code in a
> strongly
> typed way (like for the bindings) instead of using isInline to decide
> what to do everytime you get a ComplexAttribute.
My resistance to this idea is having more and more xml creap into our
feature model. If we had to I would prefer to mirror the FeatureType
concept of a "default". But I really don't think we have to in this
case....
Jody
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
