[email protected] ha scritto: > Hi Justin, > > Thank's for looking at this. > I don't think e can be null, because on the very top of the method, it's > doing something to it. > > if ( e instanceof PropertyName ) { > name = (PropertyName) e; > } > > It would throw NullPointerException before it gets to the null checking bit. > Is it OK to commit now?
I'm missing something here. BBOXImpl is ready and able to deal with a null property name, and will extract the default geometry of the feature. That is the expected behavior btw, anything changing it will break WFS CITE tests. However, looking at the GeoServer code, it seems we're using the empty string "" to represent the default geometry as opposed to null, and you're right, the existing code will break with an exception if the expression passed into the property is null (it will throw an IllegalArgumentException at line 299 thought, since "null instanceof PropertyName" will return false). Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
