Hi,
Just cleaning up my outstanding issues.
If no one minds I'm going to commit this change sometime tomorrow.
I'll add the null checking bit just in case.
Let me know otherwise.
Cheers
Rini
Rini Angreani wrote:
>
> Hi Justin,
>
> Thank's for looking at this.
> I don't think e can be null, because on the very top of the method, it's
> doing something to it.
>
> if ( e instanceof PropertyName ) {
> name = (PropertyName) e;
> }
>
> It would throw NullPointerException before it gets to the null checking
> bit.
> Is it OK to commit now?
>
> Thank's
> Rini
>
> -----Original Message-----
> From: Justin Deoliveira [mailto:[email protected]]
> Sent: Tuesday, 24 November 2009 11:37 PM
> To: Angreani, Rini (E&M, Kensington)
> Cc: [email protected]
> Subject: Re: [Geotools-devel] GEOT-2827: bbox queries for app-schema
>
> Hi Rini,
>
> I think Jody is the unofficial maintainer of the filter stuff but he is
> traveling at teh moment so I will give it my 2c.
>
> All in all I think the patch is ok. It does however change some behavior
> . Basically if code was doing this before:
>
> ff.bbox(null, 1, 2 , 3 ,4, "name")
>
> It will now not have the desired affect unless i am missing something. I
> would say instead of removing the line guard it with a check:
>
> if (e == null) {
> bbox.setPropertyName(name.getPropertyName());
> }
>
> 2c.
>
> -Justin
>
> [email protected] wrote:
>>
>> Hi list,
>>
>> I submitted a patch for http://jira.codehaus.org/browse/GEOT-2827 more
>> than a week ago, and it's still unassigned.
>> I'm not sure who the module maintainer is for that module (core filter).
>> It's a one line change, but quite important for bounding box queries in
>> complex features.
>> If you want to run bounding box query with a specific property name (in
>> the case where there are more than one geometries per feature), it'd fail
>> because it accidentally (and unnecessarily) removes the namespace for the
>> property names.
>> Can anyone advise?
>>
>> Thank's
>>
>> Rini
>>
>> ------------------------------------------------------------------------------
>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
>> 30-Day
>> trial. Simplify your report design, integration and deployment - and
>> focus on
>> what you do best, core application coding. Discover what's new with
>> Crystal Reports now. http://p.sf.net/sfu/bobj-july
>> _______________________________________________
>> Geotools-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
> 30-Day
> trial. Simplify your report design, integration and deployment - and focus
> on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
View this message in context:
http://n2.nabble.com/GEOT-2827-bbox-queries-for-app-schema-tp4036914p4329791.html
Sent from the geotools-devel mailing list archive at Nabble.com.
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
