On 04/09/2011 04:20 PM, Jody Garnett wrote: > That is a great idea :-) +1 on creating an unsupported module :-)
I'm glad your're happy. > If you have not already done so you will need to go though the motions > outlined in > the developers guide > (http://docs.geotools.org/latest/developer/guide/roles/roles.html) of sending > a > code contribution agreement in; when that is in the mail we can set you up > with > svn access. I will comply. > How about the following for no confusion: > > - gt-mark-wkt Agreed. > Maybe if we ask nice the other two could be renamed to match. > > Notes: > - I know it is an internal detail but the name of your factory > ShapeMarkFactory > may be confusing for those expecting a Java Shape? Well, the code changed a bit since I posted the patch, now the classes have been renamed to: WKTMarkFactory (WTK shapes) and MeteoMarkFactory (additional Java shape symbols). > - Oh, looking at the details, the single factory supports two things :-) I > would > recommend a single factory but it is a matter of style so probably not > valuable > feedback. See above. Anyway, since WKT can render curves as well (thanks to WKTReader2), I presume the latter factory (MeteoMarkFactory) might be dropped after all: I will investigate the quality of the graphic rendering. Regards, Luca Morandini http://www.lucamorandini.it ------------------------------------------------------------------------------ Xperia(TM) PLAY It's a major breakthrough. An authentic gaming smartphone on the nation's most reliable network. And it wants your games. http://p.sf.net/sfu/verizon-sfdev _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
