PrePostFilterVisitors
---------------------
Key: GEOT-3514
URL: http://jira.codehaus.org/browse/GEOT-3514
Project: GeoTools
Issue Type: Sub-task
Components: core filter
Reporter: Jody Garnett
Assignee: Jody Garnett
Part of this request includes:
- PrePostFilterVisitor.java
- FindProperty.java
- FindType.java
- GetParent.java
- Replace.java
This one is just a general feedback on visitor names; I know this is no fault
of your own....
There is a much loved/hated class called PostPreProcessFilterSplittingVisitor
... your new abstract base class PrePostFilterVisitor is close enough in name
that I am always going to be confused.
I am going to guess that you use this base class for more than just the search
(and replace) examples provided? If not I would love to call this
AbstractSearchFilterVisitor; and then the other classes would cleanly follow
from it...
Other than that I gotta say that this preVisit( object, data ) and postVisit(
object, data ) is exactly what the visitor pattern is trying to avoid (ie the
implementations are performing instance of checks in here to try and recover
the type information you just threw out.
I am going to think a bit more about what you have here and see if I can help;
it looks like you were trying to duck out of implementing filter traversal
while still being able to subclass quickly and "process" the data structure.
This is supposed to be possible with DefaultFilterVisitor; it may be a design
or documentation flaw if you did not find this usable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
