Some progress reported against http://jira.codehaus.org/browse/GEOT-3508
Eric if you can review when you get a chance; you should be able to try your
groovy tests and see if I missed anything, add comments to the Jira issue and
we can work through the results.
Summary of Actions:
- We had a problem with a base class tripping up instanceof checks (so NotImpl
would show up as a BinaryLogicalOperator), rather than accept the utility
methods as a work around I have fixed the issue with our class structure. This
should only effect code that was halfway between the opengis interfaces and the
geotools interfaces (we had one test failure as a result of this fix - and it
was a class cast exception in the test case).
- We had a number of new utility methods for the Filters class; focused on
appending and removing "children" from an existing And or Or filter. This
pointed out that geChildren() returned a mutable list - fixing that did not
introduce any troubles (except in Kevin's code)
Finally
- I have not quite gotten to terms with the PrePostFilterVisitor class; it
seems to be trying to match patterns in the filter data structure (ie find a
greaterThan filter where the propertyName is "zone"). Suggestions are welcome.
--
Jody Garnett
------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
