Hi Mauricio, I think I understand... my two concerns where:
1) That implementing equals usually goes hand in hand with implementing hash code... i rarely see one implemented without the other. 2) That the patch only seemed to implement equals only for some of the temporal filter classes, and not some of the others. In the interest of completeness I would just implement them for all. Also thinking... that since all the classes extend from BinaryTemporalOperatorImpl, and that generating hashCode() and equals() with eclipse is a breeze... will not the attached patch work? Apologies if i am misunderstanding. -Justin On Mon, Jul 18, 2011 at 1:46 PM, Mauricio Pazos <mauricio.pa...@gmail.com>wrote: > On Monday, July 18, 2011 03:37:41 PM Justin Deoliveira wrote: > > Confused... Jody are you referring to the patch? Or to something else? > > Reviewed the patch and posted some comments on the issue > > mmm... maybe, I was not clear. I only propose overide the equals method, to > compare to filter: > > aTemporalFilter.equals(otherTemporalFilter) > > It is necesary to avoid break the unit tests. > > -- > Mauricio Pazos > > > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial.
BinaryTemporalOperatorImpl.java.patch
Description: Binary data
------------------------------------------------------------------------------ Storage Efficiency Calculator This modeling tool is based on patent-pending intellectual property that has been used successfully in hundreds of IBM storage optimization engage- ments, worldwide. Store less, Store more with what you own, Move data to the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
_______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
