On Tuesday, July 19, 2011 12:09:37 AM Justin Deoliveira wrote: > Hi Mauricio, > > I think I understand... my two concerns where: > > 1) That implementing equals usually goes hand in hand > with implementing hash code... i rarely see one implemented without the > other. Ok. > > 2) That the patch only seemed to implement equals only for some of the > temporal filter classes, and not some of the others. In the interest of > completeness I would just implement them for all. >
Of course. > Also thinking... that since all the classes extend from > BinaryTemporalOperatorImpl, and that generating hashCode() and equals() > with eclipse is a breeze... will not the attached patch work? CQL only requires After, Before and During, but I agree all temporal filter should implement equals and hash methods. I did not want to work more in this littel improvement because I did not know if someone is working in the main module (I supposed you). Well, ... If you agree, I could add the patch for equals and hash code implementation for all temporal filters. ? > > Apologies if i am misunderstanding. No problem -- Mauricio Pazos ------------------------------------------------------------------------------ Magic Quadrant for Content-Aware Data Loss Prevention Research study explores the data loss prevention market. Includes in-depth analysis on the changes within the DLP market, and the criteria used to evaluate the strengths and weaknesses of these DLP solutions. http://www.accelacomm.com/jaw/sfnl/114/51385063/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
