On Sun, May 20, 2012 at 4:43 AM, Brett Walker <[email protected]> wrote: > Hi All, > > I have investigated this further and found a solution to fix the Build for > the H2 DataStore. > > In replicating this issue it was not sufficient to run this test in > isolation. It had to be run in conjunction with other tests. The previous > state of the H2 DataStore had an effect on the running of this test. > > I think that the JDBC framework for testing is suspect. It doesn't force a > test to cleanup after itself. Whatever it creates and leaves behind can > affect successive tests. Not really a unit test. Just my thoughts here; > correct me here if I am wrong.
The current way it works is by design, so that you can inspect the table contents after a failed test run and guess what went wrong. What we want is each test to cleanup whatever it uses before it uses it (in case there was something left from previous run), something the H2EmtpyTest did not do > > At the moment I am getting together a minimal patch to solve this issue. The > resolution revolves around the configuration of the Empty H2 DataStore. > Rather simple if you are familiar with this sections of the code base. I'm > more familiar with it now. > > I'll create a JIRA issue tomorrow with the patch attached. Your comments are > most welcome. Yep, unfortunately there are two tests using the same table and the one you patched failed to perform full cleanup before running. Your patch seems to fix it. I'm now in a rush on some other work and then have to travel, if nobody applies the patch by next week I'll do it myself Cheers Andrea -- Ing. Andrea Aime GeoSolutions S.A.S. Tech lead Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 962313 mob: +39 339 8844549 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.youtube.com/user/GeoSolutionsIT http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
