On Mon, Jun 4, 2012 at 9:32 AM, Brett Walker <[email protected]>wrote:
> Hi Andrea,****
>
> ** **
>
> The formatting changes I made were necessary because I placed large blocks
> of code within a try/finally block. To preserve readability I needed to
> indent the code. If I have done this wrong I apologise. If it is just that
> file with no try/finally block requiring an indent then it is an over site
> from me.
>
Ah, I see.
> ****
>
> ** **
>
> > I see in BasicSQLDialect that you look into the z of teh geometry to
> determine the dimension,****
>
> > imho this should be done the other way, just like we do with srid: a
> geometry is saved as****
>
> > 3d if the database accepts 3d data, not the other way around.****
>
> > If a 2d geometry is saved in a 3d database it must get in without
> issues. ****
>
> > Vice versa is indeed debatable, in my patch I forced 3d geoms to 2d if
> the database says so, silently,****
>
> > but it's mostly a convenience (though I believe I prefer this behavior
> rather than an exception,****
>
> > the data might be coming out of a processing chain that left some 3d
> bits in a data that is meant****
>
> > to be saved as 2d, if we throw exceptions the caller will be forced to
> manually shave****
>
> > off the third dimension).****
>
> ** **
>
> 2D into 3D I would call an error. Setting the third dimension to NaN is
> forcing a projection/transformation onto the data. A simple, trivial and
> naive projection/transformation, but the intent of the table may be
> violated by this. This assumption, I feel, may cause hidden problems.****
>
> ** **
>
> 3D into 2D I would also call an error for the same reason.
>
Eh, I disagree strongly on this one, 2D into 3D is a case in which one
should never throw an exception to me,
and out of line with the default GeoTools behavior, which tries to adapt
towards the target type (try to insert a linestring
into a multilinstring attribute, or a string "1234" into a integer
attribute, and you'll see, there are converters in place
that transform data towards the expected type).
Devs, please provide feedback on this one, we need more opinions.
> ****
>
> ** **
>
> The most important thing for me was to get the PostGIS test to pass. This
> directed me to do things in the fashion I did.****
>
> ** **
>
> I’m happy to provide another point of testing. I am running on Windows 7
> 64-bit, Postgres v9.1.3 64-bit, PostGIS v2.0 64-bit.
>
Ah nice, there are no (very) active developers left on Windows. I'm trying
to setup at least a build server, but it will be a XP 32 bit (since that's
what the licenses available allow us to use).
Cheers
Andrea
--
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
