Hi Ben, I noticed the API change.
It lost the ability to supply a default value. I wasn't impressed with it. If you look at my patch to help with the upgrade it might give you some ideas in how to address the GeoServer problems. As I said in the original post; I ' brutalise a method' to get it to pass the existing unit tests. Some of my original questions still stand. Are my changes sufficient or are additional unit tests required? Brett -----Original Message----- From: Ben Caradoc-Davies [mailto:[email protected]] Sent: Thursday, 18 July 2013 2:20 PM To: Michael Bedward Cc: [email protected] Subject: Re: [Geotools-devel] FW: Pull Request to upgrade JAITools There is an API change. Looks like wps-core needs to use a builder rather than directly invoking a constructor. Generics might also have been added. On 18/07/13 11:55, Michael Bedward wrote: > It was GeoSolutions that urgently wanted the bug fixes to JAITools > that are contained in v1.3.1. That was a few months ago, so it seems > surprising that neither GeoTools or GeoServer have taken advantage of > them. If that's due to any continuing problems at the JAITools end, > let me know. > > Michael > > On 18 July 2013 13:39, Ben Caradoc-Davies <[email protected]> wrote: >> Note that it breaks GeoServer wps-core on master and 2.3.x: >> >> Build failure in wps-core CoverageUtilities caused by jaitools >> upgrade >> https://jira.codehaus.org/browse/GEOS-5892 >> >> On 18/07/13 08:41, Michael Bedward wrote: >>> Just poking my nose in here although it's not really my business... >>> The 1.3.1 version contains a number of bug fixes, including >>> important contributions from Simone, so it would be nice to move up >>> to it as soon as possible. >>> >>> Michael >>> >>> >>> On 18 July 2013 09:58, Brett Walker <[email protected]> wrote: >>>> I have no need for it to be in the 10 release. >>>> >>>> I did find a bug when building using jdk7 on a different matter altogether. >>>> >>>> I have talked to Andrea about this. >>>> >>>> Brett >>>> >>>> Sent from my iPad >>>> >>>> On 18/07/2013, at 9:52 AM, "Jody Garnett" <[email protected]> wrote: >>>> >>>> Were you expecting this in the current release? If so please advise. >>>> >>>> (And thanks for stepping up with all the pull request Brett) >>>> >>>> -- >>>> Jody Garnett >>>> >>>> On Thursday, 18 July 2013 at 2:58 AM, Simone Giannecchini wrote: >>>> >>>> Ciao Bret, >>>> I had a quick look and I am happy withe changes. I will create a >>>> jira and backport to 9.x >>>> >>>> Regards, >>>> Simone Giannecchini >>>> == >>>> Our support, Your Success! Visit http://opensdi.geo-solutions.it >>>> for more information. >>>> == >>>> >>>> Ing. Simone Giannecchini >>>> @simogeo >>>> Founder/Director >>>> >>>> GeoSolutions S.A.S. >>>> Via Poggio alle Viti 1187 >>>> 55054 Massarosa (LU) >>>> Italy >>>> phone: +39 0584 962313 >>>> fax: +39 0584 1660272 >>>> mob: +39 333 8128928 >>>> >>>> http://www.geo-solutions.it >>>> http://twitter.com/geosolutions_it >>>> >>>> ------------------------------------------------------- >>>> >>>> >>>> On Wed, Jul 17, 2013 at 3:28 AM, Brett Walker >>>> <[email protected]> wrote: >>>> >>>> >>>> >>>> -----Original Message----- >>>> From: Michael Bedward [mailto:[email protected]] >>>> Sent: Wednesday, 17 July 2013 11:18 AM >>>> To: Brett Walker >>>> Cc: [email protected]; [email protected] >>>> Subject: Re: Pull Request to upgrade JAITools >>>> >>>> Hi Brett, >>>> >>>> Thanks for this work. >>>> >>>> Yes, there were substantial changes to RangeLookupTable and related >>>> classes to fix thread safety, so it's no surprise that you had to >>>> hack things at the GeoTools end. However, I don't know the >>>> CoverageUtilities code at all - it would be best to ask Simone, Andrea or >>>> Daniele to review it. >>>> >>>> Michael >>>> >>>> >>>> On 16 July 2013 22:21, Brett Walker <[email protected]> wrote: >>>> >>>> Hi, >>>> >>>> I have made a pull request to upgrade JAITools to version 1.3.1. >>>> >>>> To get the build to pass it seems that I had to brutalise a method >>>> in CoverageUtilities.java >>>> (https://github.com/brett-walker/geotools/commit/35ee8f8434f2dbb435 >>>> 622 >>>> 671f725a08e295df848) >>>> >>>> A question for Jody or Michael. >>>> >>>> Do the changes look right? Have I changed the method's meaning too >>>> drastically? Or is the change from version 1.3.0 to 1.3.1 to >>>> drastic for CoverageUtilities do be altered that the upgrade is not >>>> possible? >>>> >>>> The process-raster module, of which the CoverageUtilities is apart, >>>> is in the unsupported part of GeoTools. >>>> >>>> Brett >>>> >>>> >>>> ------------------------------------------------------------------- >>>> ----------- See everything from the browser to the database with >>>> AppDynamics Get end-to-end visibility with application monitoring >>>> from AppDynamics Isolate bottlenecks and diagnose root cause in >>>> seconds. >>>> Start your free trial of AppDynamics Pro today! >>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ost >>>> g.clktrk _______________________________________________ >>>> GeoTools-Devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>> >>>> >>>> >>>> ------------------------------------------------------------------- >>>> ----------- See everything from the browser to the database with >>>> AppDynamics Get end-to-end visibility with application monitoring >>>> from AppDynamics Isolate bottlenecks and diagnose root cause in >>>> seconds. >>>> Start your free trial of AppDynamics Pro today! >>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ost >>>> g.clktrk _______________________________________________ >>>> GeoTools-Devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>> >>> >>> -------------------------------------------------------------------- >>> ---------- See everything from the browser to the database with >>> AppDynamics Get end-to-end visibility with application monitoring >>> from AppDynamics Isolate bottlenecks and diagnose root cause in >>> seconds. >>> Start your free trial of AppDynamics Pro today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg >>> .clktrk _______________________________________________ >>> GeoTools-Devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >> >> -- >> Ben Caradoc-Davies <[email protected]> Software Engineer >> CSIRO Earth Science and Resource Engineering Australian Resources >> Research Centre >> >> --------------------------------------------------------------------- >> --------- See everything from the browser to the database with >> AppDynamics Get end-to-end visibility with application monitoring >> from AppDynamics Isolate bottlenecks and diagnose root cause in >> seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg. >> clktrk _______________________________________________ >> GeoTools-Devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geotools-devel > > ---------------------------------------------------------------------- > -------- See everything from the browser to the database with > AppDynamics Get end-to-end visibility with application monitoring from > AppDynamics Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.c > lktrk _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > -- Ben Caradoc-Davies <[email protected]> Software Engineer CSIRO Earth Science and Resource Engineering Australian Resources Research Centre ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
