He must be fine with it.
He merged my pull request and back-ported it to the 9.x branch
The way I seemed to fixed the default value is, and this is my point of
uncertainty, can be seen in the following code extract:
for (int i = 0; i < size; i++) {
final Range range = classificationRanges.get(i);
final Class<? extends Number> rangeClass = range.getMin().getClass();
if (widestClass != rangeClass) {
widestClass = ClassChanger.getWidestClass(widestClass, rangeClass);
}
final int reference = useCustomOutputPixelValues ? outputPixelValues [i]
: i + 1;
rltBuilder.add(range, convert(reference, noDataValue.getClass()));
<== Adding the ranges with appropriate lookup value
}
// Add the largest range that contains the no data value
rltBuilder.add(new Range(getClassMinimum(widestClass), true,
getClassMaximum(widestClass), true), noDataValue); <=== this is how I added
the no data (default) value. Is this appropriate to add this range lookup last
to support a no data (default) value?
Brett
-----Original Message-----
From: Michael Bedward [mailto:[email protected]]
Sent: Thursday, 18 July 2013 3:20 PM
To: Brett Walker
Cc: Ben Caradoc-Davies; [email protected]
Subject: Re: [Geotools-devel] FW: Pull Request to upgrade JAITools
On 18 July 2013 14:43, Brett Walker <[email protected]> wrote:
> It lost the ability to supply a default value. I wasn't impressed with it.
Concerning GS - I know nothing :)
Concerning JAITools and your not being impressed - I suggest you discuss any
concerns with Simone since he discovered the problems with the previous
implementation of RangeLookup and set the direction for the fixes /
improvements (all of which I support). He should also be the best judge, along
with Andrea, about whether upgrading to JT 1.3.1 is important for GT/GS or not.
Michael
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
