I am back on the 9.0-M3 branch (sigh) - hence the questions:
As an example the following on 9.0-M3:
-
https://github.com/geotools/geotools/blob/9.0-M1/modules/plugin/jdbc/jdbc-db2/src/main/java/org/geotools/data/db2/DB2Util.java
Let me check on master:
-
https://github.com/geotools/geotools/blob/master/modules/plugin/jdbc/jdbc-db2/src/main/java/org/geotools/data/db2/DB2Util.java
It still has the IBM header - so I do not think the entire module is
written by you:
/*
* GeoTools - The Open Source Java GIS Toolkit
* http://geotools.org
* (C) Copyright IBM Corporation, 2005-2007. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation;
* version 2.1 of the License.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
*/
So looking at that, it does not say (c) Open Source Geospatial Foundation,
and we have correctly preserved that header.
(So very much like we noted in our review).
The consequence is that this was never assigned over to us and is (c) IBM.
On the plus side it provided under an LGPL license, so we can continue to
distribute it.
1) So best case we find David Adler and ask IBM legal to sign our new easy
to understand code contribution license. Do you have his contact details?
2) We can remove the code - if you really are not using the above?
3) We can make a note in the docs (
http://docs.geotools.org/latest/userguide/library/jdbc/db2.html and
http://docs.geotools.org/latest/userguide/welcome/license.html )
--
Jody
On Tue, Aug 20, 2013 at 8:49 PM, Christian Mueller <
christian.muel...@os-solutions.at> wrote:
> Hi Jody.
>
> This file is quite old. Some facts about the db2-ng module.
>
> - The entire code was written by me
> - I am the module maintainer
> - There are no code contributions from David or the IBM
> - The stub jar mentioned above is gone, the whole module uses only the
> JDBC API
>
> I see no problems here, please change what you have to change.
>
> Cheers
> Christian
>
>
>
>
>
>
>
>
>
> On Tue, Aug 20, 2013 at 6:44 AM, Jody Garnett <jody.garn...@gmail.com>wrote:
>
>> Just to bring this to your attention Christian:
>>
>> These ones are actually a blocker, preventing DB2 from being in upcoming
>> releases.
>>
>> Due to the refactor to jdbc-ng we do not have out "review" file that
>> collected notes during incubation.
>>
>> Let me see if I can find that:
>> -
>> https://github.com/geotools/geotools/blob/2.6.6/modules/plugin/db2/src/site/apt/review.apt
>>
>> Looks like from the above notes that we need IBM to sign the code
>> contribution agreement....
>> Jody
>> --- contents of review.apt ---
>>
>> Module DB2
>> ~~~~~~~~~~
>>
>>
>> Module Maintainer: David Adler
>>
>> IP Review:
>>
>> * Jody Garnett, July 9th, 2006
>>
>> * Adrian Custer, June 2008
>>
>>
>> STATUS: DIRTY
>>
>>
>> Code is a mess, see below.
>> http://jira.codehaus.org/browse/GEOT-1879
>>
>> Resource origin and license unknown.
>> http://jira.codehaus.org/browse/GEOT-1880
>>
>>
>> This module is interesting in that it operatings against a comercial
>> database, leaving us without the
>>
>> rights to distribute a jdbc driver in jar form. As with other modules in
>> this situtation we need to
>> produce a stub jar based on what is needed to make the module compile.
>> This is viewed as being similar
>>
>> in spirit to use of a C++ header file and not of interest in an IP review.
>>
>>
>> The header contained in this file leaves me with a question:
>>
>> -------------------------------------------------------------------------
>> /*
>> * Geotools2 - OpenSource mapping toolkit
>> * http://geotools.org
>>
>> * (C) Copyright IBM Corporation, 2005. All rights reserved.
>> *
>>
>> * This library is free software; you can redistribute it and/or
>> * modify it under the terms of the GNU Lesser General Public
>>
>> * License as published by the Free Software Foundation;
>> * version 2.1 of the License.
>> *
>>
>> * This library is distributed in the hope that it will be useful,
>> * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>
>> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> * Lesser General Public License for more details.
>>
>> *
>> */
>> -------------------------------------------------------------------------
>>
>> That is this code is has not had copyright assigned to the GeoTools PMC,
>> so I am uncomfortable updating the headers with out first talking to
>>
>> David Adler.
>>
>> We can either proceed to assign copyright to the GeoTools PMC, or wait
>> until we move to OSGEO giving IBM a chance to formally donate code to
>> the OSGO Foundation.
>>
>> Note we have publically thanks IBM for their involvement with GeoTools
>> at the first Where 2.0 conference. This (C) with all rights reserved
>>
>> was a surprise to me.
>>
>>
>>
>> * org.geotools.data.db2
>> ~~~~~~~~~~~~~~~~~~~~~
>> Added in GeoTools 2.1 to facilitate use of DB2 with GeoServer and uDig.
>>
>> * Headers updated to GeoTools - OpenSource mapping toolkit
>>
>> * (C) IBM presents a management issues
>>
>> * LGPL license is compatible, so library use at least is not compromized
>>
>> -
>>
>>
>> On Tue, Aug 20, 2013 at 12:15 AM, Jody Garnett <jody.garn...@gmail.com>wrote:
>>
>>> So we were able to answer a few things in todays meeting, but a number
>>> of files are still confusing.
>>>
>>> The following files:
>>> DB2WKBConstants.java
>>> DB2WKBWriter.java
>>> DB2FilterToSQL.java
>>> db2/DB2WKBReader.java
>>> DB2Util.java
>>>
>>> Have the following "contains copyright to IBM…all rights reserved"
>>>
>>> Which would make them non open source!
>>>
>>> Q: Do we think this was David Adler leaving his eclipse code template
>>> settings on?
>>> Q: Do we need to rewrite the above files?
>>>
>>> --
>>> Jody Garnett
>>>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Introducing Performance Central, a new site from SourceForge and
>> AppDynamics. Performance Central is your source for news, insights,
>> analysis and resources for efficient Application Performance Management.
>> Visit us today!
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>> _______________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>
>
> --
> DI Christian Mueller MSc (GIS), MSc (IT-Security)
> OSS Open Source Solutions GmbH
>
>
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
