Thanks Christian I will 'git' right on that next.
--
Jody Garnett
On Wednesday, 21 August 2013 at 8:30 PM, Christian Mueller wrote:
> Hi Jody
>
> Here is the pull request
>
> https://github.com/geotools/geotools/pull/251
>
> Since this was my first pull request, I hope it is correct :-)
>
> Cheers
> Christian
>
>
>
>
> On Tue, Aug 20, 2013 at 3:46 PM, Jody Garnett <jody.garn...@gmail.com
> (mailto:jody.garn...@gmail.com)> wrote:
> > That is great, thanks for the clarification - do you think you (as the
> > author) could put pull request in fixing those headers? Then I can cherry
> > pick it onto the 9.0-M1 branch.
> >
> > Also: While I can link to this email discussion in the archives (public
> > record etc…), it would be nice if you could email
> > sharon.corb...@eclipse.org (mailto:sharon.corb...@eclipse.org) with this
> > clarification.
> > --
> > Jody Garnett
> >
> >
> > On Tuesday, 20 August 2013 at 11:19 PM, Christian Mueller wrote:
> >
> > > Hi Jody, I found the IBM header in
> > >
> > > DB2WKBReader.java
> > > DB2WKBConstants.java
> > > DB2FilterToSQL.java
> > > DB2WKBWriter.java
> > > DB2Util.java
> > >
> > >
> > > In DB2WKBConstants.java, I found a reference to David Adler.
> > >
> > > All those classes are still used and have been reworked/created
> > > completely by me. The only thing I did is copying some snippets (like
> > > constants) from Davids code. The IBM header is a copy & paste error.
> > > David Adler did not contribute to the db2-ng module.
> > >
> > > I had overseen the IBM copyright in the header, my mistake, sorry.
> > >
> > > Cheers
> > > Christian
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Tue, Aug 20, 2013 at 2:01 PM, Jody Garnett <jody.garn...@gmail.com
> > > (mailto:jody.garn...@gmail.com)> wrote:
> > > > Christian I have provided the following response (on your behalf as
> > > > module maintainer):
> > > >
> > > > Okay checking our notes (see link) this code remains the property of
> > > > IBM. An IBM employee directly worked with the project using an LGPL
> > > > license allowing us to distribute. We were going to revisit CLA after
> > > > joining the OSGeo foundation. The current module maintainer is not sure
> > > > if these classes are still used.
> > > >
> > > > Do you agree or have anything to add?
> > > >
> > > >
> > > > On Tue, Aug 20, 2013 at 8:49 PM, Christian Mueller
> > > > <christian.muel...@os-solutions.at
> > > > (mailto:christian.muel...@os-solutions.at)> wrote:
> > > > > Hi Jody.
> > > > >
> > > > > This file is quite old. Some facts about the db2-ng module.
> > > > >
> > > > > - The entire code was written by me
> > > > > - I am the module maintainer
> > > > > - There are no code contributions from David or the IBM
> > > > > - The stub jar mentioned above is gone, the whole module uses only
> > > > > the JDBC API
> > > > >
> > > > > I see no problems here, please change what you have to change.
> > > > >
> > > > > Cheers
> > > > > Christian
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Tue, Aug 20, 2013 at 6:44 AM, Jody Garnett <jody.garn...@gmail.com
> > > > > (mailto:jody.garn...@gmail.com)> wrote:
> > > > > > Just to bring this to your attention Christian:
> > > > > >
> > > > > > These ones are actually a blocker, preventing DB2 from being in
> > > > > > upcoming releases.
> > > > > >
> > > > > > Due to the refactor to jdbc-ng we do not have out "review" file
> > > > > > that collected notes during incubation.
> > > > > >
> > > > > > Let me see if I can find that:
> > > > > > -
> > > > > > https://github.com/geotools/geotools/blob/2.6.6/modules/plugin/db2/src/site/apt/review.apt
> > > > > >
> > > > > > Looks like from the above notes that we need IBM to sign the code
> > > > > > contribution agreement....
> > > > > > Jody
> > > > > > --- contents of review.apt ---
> > > > > > Module DB2
> > > > > > ~~~~~~~~~~
> > > > > >
> > > > > > Module Maintainer: David Adler
> > > > > >
> > > > > > IP Review:
> > > > > >
> > > > > > * Jody Garnett, July 9th, 2006
> > > > > >
> > > > > > * Adrian Custer, June 2008
> > > > > >
> > > > > >
> > > > > > STATUS: DIRTY
> > > > > >
> > > > > > Code is a mess, see below.
> > > > > > http://jira.codehaus.org/browse/GEOT-1879
> > > > > > Resource origin and license unknown.
> > > > > > http://jira.codehaus.org/browse/GEOT-1880
> > > > > >
> > > > > > This module is interesting in that it operatings against a
> > > > > > comercial database, leaving us without the
> > > > > > rights to distribute a jdbc driver in jar form. As with other
> > > > > > modules in this situtation we need to
> > > > > > produce a stub jar based on what is needed to make the module
> > > > > > compile. This is viewed as being similar
> > > > > > in spirit to use of a C++ header file and not of interest in an
> > > > > > IP review.
> > > > > >
> > > > > > The header contained in this file leaves me with a question:
> > > > > >
> > > > > > -------------------------------------------------------------------------
> > > > > >
> > > > > > /*
> > > > > > * Geotools2 - OpenSource mapping toolkit
> > > > > > * http://geotools.org
> > > > > > * (C) Copyright IBM Corporation, 2005. All rights reserved.
> > > > > > *
> > > > > > * This library is free software; you can redistribute it and/or
> > > > > > * modify it under the terms of the GNU Lesser General Public
> > > > > > * License as published by the Free Software Foundation;
> > > > > > * version 2.1 of the License.
> > > > > > *
> > > > > > * This library is distributed in the hope that it will be useful,
> > > > > > * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > > > > > * Lesser General Public License for more details.
> > > > > > *
> > > > > > */
> > > > > > -------------------------------------------------------------------------
> > > > > >
> > > > > > That is this code is has not had copyright assigned to the
> > > > > > GeoTools PMC,
> > > > > > so I am uncomfortable updating the headers with out first talking
> > > > > > to
> > > > > > David Adler.
> > > > > >
> > > > > > We can either proceed to assign copyright to the GeoTools PMC, or
> > > > > > wait
> > > > > > until we move to OSGEO giving IBM a chance to formally donate
> > > > > > code to
> > > > > > the OSGO Foundation.
> > > > > >
> > > > > > Note we have publically thanks IBM for their involvement with
> > > > > > GeoTools
> > > > > > at the first Where 2.0 conference. This (C) with all rights
> > > > > > reserved
> > > > > > was a surprise to me.
> > > > > >
> > > > > >
> > > > > > * org.geotools.data.db2
> > > > > > ~~~~~~~~~~~~~~~~~~~~~
> > > > > > Added in GeoTools 2.1 to facilitate use of DB2 with GeoServer and
> > > > > > uDig.
> > > > > >
> > > > > > * Headers updated to GeoTools - OpenSource mapping toolkit
> > > > > >
> > > > > > * (C) IBM presents a management issues
> > > > > >
> > > > > > * LGPL license is compatible, so library use at least is not
> > > > > > compromized
> > > > > > -
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Tue, Aug 20, 2013 at 12:15 AM, Jody Garnett
> > > > > > <jody.garn...@gmail.com (mailto:jody.garn...@gmail.com)> wrote:
> > > > > > > So we were able to answer a few things in todays meeting, but a
> > > > > > > number of files are still confusing.
> > > > > > >
> > > > > > > The following files:
> > > > > > > DB2WKBConstants.java
> > > > > > > DB2WKBWriter.java
> > > > > > > DB2FilterToSQL.java
> > > > > > > db2/DB2WKBReader.java
> > > > > > > DB2Util.java
> > > > > > >
> > > > > > > Have the following "contains copyright to IBM…all rights
> > > > > > > reserved"
> > > > > > >
> > > > > > > Which would make them non open source!
> > > > > > >
> > > > > > > Q: Do we think this was David Adler leaving his eclipse code
> > > > > > > template settings on?
> > > > > > > Q: Do we need to rewrite the above files?
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Jody Garnett
> > > > > > >
> > > > > >
> > > > > >
> > > > > > ------------------------------------------------------------------------------
> > > > > > Introducing Performance Central, a new site from SourceForge and
> > > > > > AppDynamics. Performance Central is your source for news, insights,
> > > > > > analysis and resources for efficient Application Performance
> > > > > > Management.
> > > > > > Visit us today!
> > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> > > > > > _______________________________________________
> > > > > > GeoTools-Devel mailing list
> > > > > > GeoTools-Devel@lists.sourceforge.net
> > > > > > (mailto:GeoTools-Devel@lists.sourceforge.net)
> > > > > > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > DI Christian Mueller MSc (GIS), MSc (IT-Security)
> > > > > OSS Open Source Solutions GmbH
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > DI Christian Mueller MSc (GIS), MSc (IT-Security)
> > > OSS Open Source Solutions GmbH
> > >
> >
>
>
>
> --
> DI Christian Mueller MSc (GIS), MSc (IT-Security)
> OSS Open Source Solutions GmbH
>
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
