On Sun, Nov 10, 2013 at 3:17 AM, Jody Garnett <[email protected]>wrote:
> There is a fair bit of overlap with this page:
> - http://docs.geotools.org/latest/developer/procedures/hack.html
>
> I will combine the two and submit a pull request for your review.
>
Hi Jody,
thanks for the improvements, I believe you're referring to this one right?
https://github.com/geotools/geotools/pull/311
Nice to see you axed the hacking page.
The contributor role and pull request page are still having quite a bit of
overlap.
Personally I prefer the contributor role setup, it's quicker to read and
better organized
in terms of things you have to do before the pull request.
One thing that still bothers me is that regardless of the advice to talk
first,
the pull request page still puts quite a bit of emphasis on the discussion
about the
pull request contents in github.
Which is fine to a degree, but the whole objective of my original pull
request
was to make people talk before coding, instead of talk after the pull
request is done.
The discussion will still be there, but it should end up being about
details, not about the
whole thing like it is today.
One thing that I've failed to make clear in the "talk first" policy is that
we expect
people to discuss their design and get back feedback to how better develop
the code
so that it lines up with the rest of GeoTools code, to have less
duplication, to make
it more part of the library instead of an ad-hoc change to satisfy a single
need.
This is actually one of the major point point of discussing a pull request
after
the fact, that most of the time, its content are quite special purpose and
show that
the writer has little visibility of what the library already offers
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
