On Sun, Nov 10, 2013 at 10:40 AM, Jody Garnett <[email protected]>wrote:
> thanks for the improvements, I believe you're referring to this one right?
>
> https://github.com/geotools/geotools/pull/311
>
> Nice to see you axed the hacking page.
>
> Renamed and rewrote with your words as procedures/contribute.rst
>
> The contributor role and pull request page are still having quite a bit of
> overlap.
>
> Agreed, however I could not manage to separate them more in one sitting,
> however I think I found the three pages where we tell the story.
>
> Personally I prefer the contributor role setup, it's quicker to read and
> better organized
> in terms of things you have to do before the pull request.
>
> I was thinking of taking it out to the procedures page, since it describes
> how to make a contribution, rather than what the role of a contributor is.
>
Yes, makes sense.
> One thing that still bothers me is that regardless of the advice to talk
> first,
> the pull request page still puts quite a bit of emphasis on the discussion
> about the
> pull request contents in github.
>
> So here is the plan:
>
> roles/contributor <-- renaming this page to be a role rather than action
>
> procedure/contribute <-- take the discussion and talk first, how to play
> nice with others stuff hereprocecure/pull_request <-- strictly focused on
> care and feeding of pull requests (focus was on closing them when the
> conversation does not take place)
>
How about people that want to submit a patch instead?
Imho we should discourage that, pull requests getting some review tools and
a Travis build, some I'm good with just saying nothing about that option.
> Do you want to accept pull/311? And proceed from there?
>
Sure, go ahead. Or if you want to make more changes, just do them and
update the pull request.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
