On Sun, Mar 9, 2014 at 11:43 PM, Jody Garnett <[email protected]>wrote:

> Looks clear to me, thanks for getting the headers correct (sigh!).
>
> I had one general question about the design of JDBCAggregateFunctionTest (
> https://github.com/aaime/geotools/blob/b7f66c845acc3ee456cdc2db174e5f1578ddf41d/modules/library/jdbc/src/test/java/org/geotools/jdbc/JDBCAggregateFunctionTest.java
> ).
>
> Why does the test cases create a subclass to test (i.e. MyNearestVisitor
> extends NearestVisitor)?
>

Just like with all other visitors tested, we make sure they are not
actually getting passed any feature,
but are being optimized out via SQL calls instead

Cheers
Andrea

-- 
== Our support, Your Success! Visit http://opensdi.geo-solutions.it for
more information ==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to