I will go have a look at the JDBCFeatureSource code then.
Jody Garnett
On Mon, Mar 10, 2014 at 6:14 PM, Jody Garnett <[email protected]>wrote:
> Existing code turned attributeName into an expression in the constructor
> and never looked back
>
> Jody Garnett
>
>
> On Mon, Mar 10, 2014 at 6:13 PM, Andrea Aime <[email protected]
> > wrote:
>
>> On Mon, Mar 10, 2014 at 7:03 AM, Jody Garnett <[email protected]>wrote:
>>
>>> Okay went to merge this and doubled check it was mentioned in the docs.
>>>
>>> Turns out there is no collection function for this one. In looking at
>>> implementing I noticed that NearestVisitor was artificially limited to
>>> working against PropertyName expressions. I will prep a fix and issue a
>>> pull request for your review.
>>>
>>
>> No collection function... ah found them. I honestly though that was stuff
>> that we were
>> keeping for backwards compatibility. Why would anyone use those instead
>> of a visitor?
>>
>> Careful about extending the visitor to allow any expression, you'll need
>> to make sure the
>> JDBC optimization recognizes that case and does not try to optimize out
>> the visit if
>> the expression is not a property name... which hum... I'm not sure the
>> existing code
>> will handle for the others, either, I believe it will NPE instead
>>
>> Cheers
>> Andrea
>>
>> --
>> == Our support, Your Success! Visit http://opensdi.geo-solutions.it for
>> more information ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via Poggio alle Viti 1187
>> 55054 Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>> mob: +39 339 8844549
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
