n Tue, May 13, 2014 at 3:59 PM, Jody Garnett <[email protected]> wrote:
> So my first pull request at fixing our JAI start up warnings is getting
> rejected as not maintainable.
>
> // Custom GeoTools ImagingListener used to ignore common warnings
> JAI.getDefaultInstance().setImagingListener(new ImagingListener() {
> final Logger LOGGER = Logging.getLogger("javax.media.jai");
> @Override
> public boolean errorOccurred(String message, Throwable thrown,
> Object where,
> boolean isRetryable) throws RuntimeException {
> if (message.contains("Continuing in pure Java mode")) {
> LOGGER.log(Level.FINE, message, thrown);
> } else {
> LOGGER.log(Level.INFO, message, thrown);
> }
> return false; // we are not trying to recover
> }
> });
>
> Briefly GeoTools.init() was going to register an ImagingListener. The
> rejected pull request added GeoTools.init() to each test case @Before
> method.
>
Mind, I did not mean to reject the pull request, just wanted to express
concern on its (lack of) future maintability
>
> In todays meeting we hit on another approach. In the static init of our
> logging class I will check if JAI has an ImagingListener, and if it is null
> I will add in our own.
>
Right. Anyone knows if that might present issues we haven't considered?
Cheers
Andrea
--
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
